Merged
Conversation
... needed for std::numeric_limits<T>::max on WIN32 Github-Pull: bitcoin#23335 Rebased-From: 077a875
`crc32c`'s hardware accelerated code doesn't handle ARM 32-bit at all. Make the check in `configure.ac` check for this architecture explicitly. For the release binaries, the current `configure.ac` check happens to work: it enables it on aarch64 but disables it for armhf. However some combination of compiler version and settings might ostensibly cause this check to succeed on armhf (as reported on IRC). So make the 64-bit platform requirement explicit. Github-Pull: bitcoin#23045 Rebased-From: f2747d1
This was referenced Jun 9, 2022
Saleciani
approved these changes
Jun 9, 2022
Member
|
nit: Shouldn't the milestone here be 0.21.3? We already released 0.21.2... |
Member
Author
|
I'll just leave it unmilestoned. Have closed 0.21.2 given it wasn't already. |
Member
|
ACK efb9f00 |
LarryRuane
reviewed
Jun 9, 2022
Contributor
LarryRuane
left a comment
LarryRuane
left a comment
There was a problem hiding this comment.
utACK efb9f00
I verified that these diffs match the source PRs' diffs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There might not be another 0.21.x release, however these are both straight forward changes. If this isn't merged, then the pulls can remain untagged for needing backport.
Backports: