build: Fix capnp package build for Android#25322
Conversation
From `configure --help`:
--with-external-capnp use the system capnp binary (or the one specified
with $CAPNP) instead of compiling a new one (useful
for cross-compiling)
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
+1. Can you explain why this is the best / correct fix?
the capnp docs? |
|
@hebasto can you follow up here? |
The build fails during the As we are not using the
It avoids libtools relink steps.
Yes. To be precise, I mean Also, see https://github.com/capnproto/capnproto/blob/v0.7.0/c++/configure.ac#L78-L94 |
8b8edc2 build: Specify native binaries explicitly when building `capnp` package (Hennadii Stepanov) a413595 build: Fix `capnp` package build for Android (Hennadii Stepanov) Pull request description: On master (e3c08eb): ``` $ make -C depends capnp MULTIPROCESS=1 HOST=aarch64-linux-android ANDROID_SDK=$ANDROID_HOME ANDROID_NDK=$ANDROID_HOME/ndk/23.2.8568313 ANDROID_API_LEVEL=28 ANDROID_TOOLCHAIN_BIN=$ANDROID_HOME/ndk/23.2.8568313/toolchains/llvm/prebuilt/linux-x86_64/bin ... ld: error: unable to find library -lkj ... ``` This PR fixes this error, and also improves configuring according to the docs. ACKs for top commit: ryanofsky: Code review ACK 8b8edc2. I'd be a little curious to know what causes the error and how `--disable-shared` fixes it, but these changes all look good Tree-SHA512: 1b07b75f2a83932d8dc1f007e42a67d8327bd5fe4566f554dab4599e2a1e04b0144648790a1fd2ab1c295dba728586035aa0ebdbe5cf49df048ec87736895aaf
4 participants
On master (e3c08eb):
This PR fixes this error, and also improves configuring according to the docs.