Add HashWriter without ser-type and ser-version and use it where possible#25331
Merged
fanquake merged 2 commits intobitcoin:masterfrom Jul 22, 2022
Hidden character warning
The head ref may contain hidden characters: "2206-hashwriter-\ud83d\udc7d"
Merged
Add HashWriter without ser-type and ser-version and use it where possible#25331fanquake merged 2 commits intobitcoin:masterfrom
fanquake merged 2 commits intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jun 10, 2022
Closed
Member
|
Concept ACK |
Empact
reviewed
Jun 17, 2022
Empact
reviewed
Jun 17, 2022
maflcko
force-pushed
the
2206-hashwriter-
branch
from
fa9cc54 to
faa404c
Compare
added 2 commits
July 20, 2022 15:34
The moved parts can be reviewed with "--color-moved=dimmed-zebra".
maflcko
force-pushed
the
2206-hashwriter-
branch
from
faa404c to
faf9acc
Compare
Member
|
utACK faf9acc |
Contributor
|
utACK faf9acc nit: I still prefer default-initialization without |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done in the context of #25284 , but I think it also makes sense standalone.
The basic idea is that serialization type should not be initialized when it is not needed. Same for the serialization version.
So do this here for
HashWriter.CHashWriterremains in places where it is not yet possible.