test: Remove MiniWallet mempool_valid option#25356
Merged
maflcko merged 1 commit intobitcoin:masterfrom Jun 13, 2022
Hidden character warning
The head ref may contain hidden characters: "2206-test-skip-tmpa-\ud83d\udd55"
Merged
Conversation
instagibbs
approved these changes
Jun 13, 2022
Member
instagibbs
left a comment
instagibbs
left a comment
There was a problem hiding this comment.
ACK fac709456a94eec72e5b75df147e9a76f61a63b0
It's a confusing interface as-is, and these hidden checks imo are more likely to make tests less understandable.
maflcko
force-pushed
the
2206-test-skip-tmpa-
branch
from
fac7094 to
fa779de
Compare
theStack
approved these changes
Jun 13, 2022
Contributor
theStack
left a comment
theStack
left a comment
There was a problem hiding this comment.
Code-review ACK fa779de
Agree that this creates more confusion than it helps and can be removed. The journey of this parameter's logic went from "always test mempool validity" (fa085b4, introduction of the method) to "only test mempool validity if set to True" (a498acc, for performance reasons) to "never test mempool validity" (this PR).
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 15, 2022
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 2, 2022
Summary: ``` It seems an unnecessary burden to force MiniWallet call-sites to figure out for each tx whether it is mempool valid or not. The result will only be used for internal sanity checks. So remove the option: ``` Backport of [[bitcoin/bitcoin#25356 | core#25356]]. Depends on D12732. Note: most tests are not converted to MiniWallet yet, but this change is trivial enough that it's not a problem. Test Plan: ninja check-functional Reviewers: #bitcoin_abc, sdulfari Reviewed By: #bitcoin_abc, sdulfari Differential Revision: https://reviews.bitcoinabc.org/D12733
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems an unnecessary burden to force MiniWallet call-sites to figure out for each tx whether it is mempool valid or not. The result will only be used for internal sanity checks. So remove the option:
get_vsize().