p2p, doc: Use MAX_BLOCKS_TO_ANNOUNCE consistently#25404
Merged
fanquake merged 1 commit intobitcoin:masterfrom Jun 27, 2022
Merged
p2p, doc: Use MAX_BLOCKS_TO_ANNOUNCE consistently#25404fanquake merged 1 commit intobitcoin:masterfrom
fanquake merged 1 commit intobitcoin:masterfrom
Conversation
It is an inclusive upper bound according to its definition.
|
LGTM |
Raulnori77
approved these changes
Jun 18, 2022
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
krissmkii
approved these changes
Jun 19, 2022
Member
|
utACK - this was an oversight in #8305 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block announcements via headers may have up to
MAX_BLOCKS_TO_ANNOUNCE = 8entries according to the definition of this constant.However, there are a few spots saying they should have a size less than
MAX_BLOCKS_TO_ANNOUNCE. Fix these.I don't think that this is critical (this only changes behavior when we get a headers announcement with exactly
MAX_BLOCKS_TO_ANNOUNCEblocks which we can't connect), but it would be nice to handle this limit consistently.