rpc: Return incrementalrelayfee in getmempoolinfo#25439
Hidden character warning
rpc: Return incrementalrelayfee in getmempoolinfo#25439maflcko merged 1 commit intobitcoin:masterfrom
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
jarolrod
left a comment
jarolrod
left a comment
There was a problem hiding this comment.
tACK fafee78
{
"loaded": true,
"size": 1,
"bytes": 141,
"usage": 1168,
"total_fee": 0.00000141,
"maxmempool": 300000000,
"mempoolminfee": 0.00001000,
"minrelaytxfee": 0.00001000,
"incrementalrelayfee": 0.00001000,
"unbroadcastcount": 0
}
| {RPCResult::Type::STR_AMOUNT, "mempoolminfee", "Minimum fee rate in " + CURRENCY_UNIT + "/kvB for tx to be accepted. Is the maximum of minrelaytxfee and minimum mempool fee"}, | ||
| {RPCResult::Type::STR_AMOUNT, "minrelaytxfee", "Current minimum relay fee for transactions"}, | ||
| {RPCResult::Type::NUM, "unbroadcastcount", "Current number of transactions that haven't passed initial broadcast yet"} | ||
| {RPCResult::Type::NUM, "incrementalrelayfee", "minimum fee rate increment for mempool limiting or BIP 125 replacement in " + CURRENCY_UNIT + "/kvB"}, |
There was a problem hiding this comment.
- s/minimum/Minimum/ (like the other lines in the getmempoolinfo help)
- could add the unit to minrelaytxfee help
There was a problem hiding this comment.
(Would be possibly nice for these to be expressed in sats, though I suppose that would require a new RPC.)
There was a problem hiding this comment.
s/minimum/Minimum/ (like the other lines in the getmempoolinfo help)
I copied this from the getnetworkinfo RPC.
could add the unit to minrelaytxfee help
Sure, but seems unrelated.
(Would be possibly nice for these to be expressed in sats, though I suppose that would require a new RPC.)
Good point, given that the wallet is moving toward sat/vB. Not sure how to fix this, though.
fafee78 rpc: Return incrementalrelayfee in getmempoolinfo (MacroFake) Pull request description: Seems odd to return other policy info, but not the incremental relay fee ACKs for top commit: 1440000bytes: ACK bitcoin@fafee78 w0xlt: Code Review ACK bitcoin@fafee78 jarolrod: tACK fafee78 Tree-SHA512: faad0af6c039b8257acbeac913bc5dcdb2ea2db304c95e52601536c8de60eb1186e9fbb4a64a68adf476605f18022aeda16a5644a0d7912592b0977e4c029638
7 participants
Seems odd to return other policy info, but not the incremental relay fee