p2p: Set CNode::m_relays_txs=true when receiving BIP37 filters#25446
p2p: Set CNode::m_relays_txs=true when receiving BIP37 filters#25446fanquake merged 1 commit intobitcoin:masterfrom
Conversation
…lters This line was accidentally removed in bitcoin#22778.
dergoegge
changed the title
|
I see, it was removed here: https://github.com/bitcoin/bitcoin/pull/22778/files#diff-6875de769e90cec84d2e8a9c1b962cdbcda44d870d42e4215827e599e11e90e3R4090 Code review ACK e7a9133 |
vasild
left a comment
vasild
left a comment
There was a problem hiding this comment.
ACK e7a9133
So it actually happened that the redundant fields CNode::m_relays_txs and Peer::TxRelay::m_relay_txs went out of sync (one is true while the other is false) :-(
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
… BIP37 filters e7a9133 [net processing] Set CNode::m_relays_txs=true when receiving BIP37 filters (dergoegge) Pull request description: This line was accidentally removed in bitcoin#22778. Receiving a `filterload` message implies that we should relay txs to the sender (`CNode::m_relays_txs = true`). `CNode::m_relays_txs` is only used for the inbound eviction logic, so removing the line might have slightly changed the eviction behaviour but nothing else. ACKs for top commit: laanwj: Code review ACK e7a9133 vasild: ACK e7a9133 Tree-SHA512: 19c5df0f579f707c6c7900d12a6b71ac69e802be64f7d2fdcc40ac714c918dc4c17def164592f8836cc105a03daefefca3ca5e10423145eca8db4348c27c9cfc
|
post-merge ACK e7a9133 Thanks @dergoegge! |
6 participants
This line was accidentally removed in #22778.
Receiving a
filterloadmessage implies that we should relay txs to the sender (CNode::m_relays_txs = true).CNode::m_relays_txsis only used for the inbound eviction logic, so removing the line might have slightly changed the eviction behaviour but nothing else.