ci: Update Windows task image up to `visualstudio2022` by hebasto · Pull Request #25460 · bitcoin/bitcoin

hebasto · 2022-06-23T18:55:43Z

Besides upgrading Visual Studio, which seems inevitable, this PR also:

bumps vcpkg to the latest version (previous one was in ci: Bump vcpkg to the latest version 2022.04.12 #24847)
fixes cache size limit for ccache

.cirrus.yml

maflcko · 2022-06-24T05:36:27Z

Looks like it is now?

maflcko · 2022-06-24T05:37:26Z

Please revert fa72e0b as well

hebasto · 2022-06-24T07:51:02Z

Looks like it is now?

Still getting "Agent is not responding!" error (

hebasto · 2022-06-24T21:22:14Z

@sipsorcery

~~Could you look at linker error here? (fwiw, I have wiped all caches)~~

nm, forgot to update PlatformToolset :)

.cirrus.yml

Dependency changes: - boost-* 1.78.0#0 -> 1.79.0#0

hebasto · 2022-06-25T12:02:08Z

@MarcoFalke

Please revert fa72e0b as well

See #25472.

maflcko · 2022-06-25T14:51:31Z

.cirrus.yml

  << : *FILTER_TEMPLATE
  windows_container:
-    cpu: 4
+    cpu: 6


any reason to change this? With 6 cpu it finished 1 minute earlier compared to master ( https://cirrus-ci.com/task/5018066990923776 ), so it seems like a random fluke.

Also, if someone pushes several pull requests at the same time, the scheduler will hit the total cpu limit earlier.

Also, looking at the graph, the CPU usage density is less, indicating that the 5th and 6th cpu may be idle most of the time

any reason to change this?

On master, the time required to get the task done with no caches is very close to 2 hours limit.

With 6 cpu it finished 1 minute earlier compared to master ( https://cirrus-ci.com/task/5018066990923776 ), so it seems like a random fluke.

Such comparison is not correct, because vcpkg_binary cache was invalidated for this PR. Functional tests are more then 10 minutes faster now.

Also, looking at the graph, the CPU usage density is less, indicating that the 5th and 6th cpu may be idle most of the time

~~Will 5 cpus be OK?~~ UPDATE: Odd CPU number does not work (

On master, the time required to get the task done with no caches is very close to 2 hours limit.

Ok, no objection then.

Is there a reason why vs22 needs more resources?

Is there a reason why vs22 needs more resources?

On master, with cleared caches:

time: 01:56:44

peak memory usage: 5.08 GB

On master + 156bc89 commit, with cleared caches:

time: 01:58:25

peak memory usage: 5.12 GB

Actually, there is no significant difference in resources at all.

I think it might be best to revert this. Looks like now this won't be scheduled until 4 hours later. If the CPU was reduced, so that it was scheduled earlier, it would take 15 minutes longer to run, but still finish earlier.

I think it might be best to revert this. Looks like now this won't be scheduled until 4 hours later. If the CPU was reduced, so that it was scheduled earlier, it would take 15 minutes longer to run, but still finish earlier.

Ok, But a similar situation with ARM task been observed right now.

I think it might be best to revert this.

#25483

maflcko · 2022-06-26T07:54:49Z

too bad that this doesn't fix #25472. Though, I guess it can't hurt to bump now, given that we'll have to do it anyway at some point. However, I think our windows docs should match the windows CI.

sipsorcery · 2022-06-26T08:37:47Z

@sipsorcery

~~Could you look at linker error here? (fwiw, I have wiped all caches)~~

nm, forgot to update PlatformToolset :)

I find myself doing that everytime I do a build. Maybe this PR is a good time to udate the default?

sipsorcery · 2022-06-26T08:38:19Z

ACK 3dabd28.

Currently, the time it takes to get the "Win64 native" task done with all of the caches been invalidated is very close to the 2 hours limit. This task is the only one which runs on Windows Community Cluster, therefore this change should not affect other CI tasks.

Added Visual Studio 2022.

maflcko · 2022-06-26T09:35:22Z

.cirrus.yml

    - '%x64_NATIVE_TOOLS%'
    - cd %CIRRUS_WORKING_DIR%
-    - ccache --zero-stats
+    - ccache --zero-stats --max-size=%CCACHE_SIZE%


is CCACHE_SIZE set at all?

bitcoin/.cirrus.yml

Line 6 in 0dd3477

CCACHE_SIZE: "200M"

On master:

Summary: Hits: 239 / 239 (100.0 %) Direct: 239 / 239 (100.0 %) Preprocessed: 0 / 0 Misses: 0 Direct: 0 Preprocessed: 0 Uncacheable: 10 Primary storage: Hits: 478 / 478 (100.0 %) Misses: 0 Cache size (GB): 1.35 / 5.00 (27.06 %) Use the -v/--verbose option for more details.

With this PR:

Summary: Hits: 239 / 239 (100.0 %) Direct: 239 / 239 (100.0 %) Preprocessed: 0 / 0 Misses: 0 Direct: 0 Preprocessed: 0 Uncacheable: 10 Primary storage: Hits: 478 / 478 (100.0 %) Misses: 0 Cache size (GB): 0.07 / 0.20 (32.93 %) Use the -v/--verbose option for more details.

Compare the "Cache size" string.

hebasto · 2022-06-26T09:36:12Z

Updated 3dabd28 -> 05b2d9f (pr25460.01 -> pr25460.02, diff):

addressed @MarcoFalke's comment:

However, I think our windows docs should match the windows CI.

addressed @sipsorcery's comment:

nm, forgot to update PlatformToolset :)

I find myself doing that everytime I do a build. Maybe this PR is a good time to udate the default?

sipsorcery · 2022-06-26T10:35:19Z

reACK 05b2d9f.

DrahtBot · 2022-06-26T16:42:37Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#25472 (build: Increase MS Visual Studio minimum version by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

jarolrod

ACK 05b2d9f

Changes look good to me, makes sense to update as visual studio 2019 will "will go out of support in October 2022". PR description could state some of the motivation for the update.

hebasto · 2022-06-27T05:21:50Z

ACK 05b2d9f

Changes look good to me, makes sense to update as visual studio 2019 will "will go out of support in October 2022". PR description could state some of the motivation for the update.

PR description has been just added.

…64 native" task" b1d2fb4 Revert "ci: Increase CPU number for "Win64 native" task" (Hennadii Stepanov) Pull request description: This reverts commit 849cf96. It seems this should [improve](bitcoin/bitcoin#25460 (comment)) the total CI throughput. ACKs for top commit: MarcoFalke: review ACK b1d2fb4 Tree-SHA512: 833665bbea00b695dd1c600c6a47943d47b1a2a3560886b2056544cf62542d6f91b1f2e157ad082b02b67922f1fff14029da35b1a9d85339c2bf526f41b41836

…2022

…22.09.27` 281e7c7 ci: Bump vcpkg to the latest version `2022.09.27` (Hennadii Stepanov) Pull request description: Dependency changes in [vcpkg](https://github.com/microsoft/vcpkg) (2022.06.16.1 - [2022.09.27](https://github.com/microsoft/vcpkg/releases/tag/2022.09.27)): - boost 1.79.0#0 -> 1.80.0#0 - sqlite3 3.37.2#1 -> 3.39.2#0 - zeromq 4.3.4#5 -> 4.3.4#6 The recent update was in bitcoin/bitcoin#25460. ACKs for top commit: sipsorcery: tACK 281e7c7. Tree-SHA512: 624e2506eb16fb37d1ca0a71caa12e64f8709c0ddd280e3d1e0f6a8fa2a3667b0f8a2f52d553e096c9f8cd50e4e220e23a23fdb97076d7bcdfab0951e94909a1

hebasto force-pushed the 220623-vs2022 branch from 44e150f to 5b664df Compare June 23, 2022 18:58

maflcko reviewed Jun 23, 2022

View reviewed changes

.cirrus.yml Outdated Show resolved Hide resolved

DrahtBot added the Tests label Jun 23, 2022

hebasto closed this Jun 23, 2022

maflcko added this to the 24.0 milestone Jun 24, 2022

hebasto reopened this Jun 24, 2022

maflcko reviewed Jun 25, 2022

View reviewed changes

.cirrus.yml Outdated Show resolved Hide resolved

ci: Update Windows task image up to visualstudio2022

156bc89

hebasto force-pushed the 220623-vs2022 branch from 5b664df to 156bc89 Compare June 25, 2022 09:31

hebasto added 2 commits June 25, 2022 12:36

ci: Limit ccache cache size properly on "Win64 native" task

b9a5a9b

ci: Bump vcpkg to the latest version

a18c4c1

Dependency changes: - boost-* 1.78.0#0 -> 1.79.0#0

hebasto force-pushed the 220623-vs2022 branch from 19a9e35 to 3dabd28 Compare June 25, 2022 11:56

hebasto mentioned this pull request Jun 25, 2022

build: Increase MS Visual Studio minimum version #25472

Merged

hebasto changed the title ~~ci: Update Windows task image up to visualstudio2022~~ ci: Update Windows task image up to visualstudio2022 Jun 25, 2022

hebasto marked this pull request as ready for review June 25, 2022 12:26

maflcko reviewed Jun 25, 2022

View reviewed changes

hebasto added 3 commits June 26, 2022 11:07

doc: Make Windows build docs match the CI task

460c6c7

Added Visual Studio 2022.

build: Bump default PlatformToolset for Visual Studio 2022

05b2d9f

hebasto force-pushed the 220623-vs2022 branch from 3dabd28 to 05b2d9f Compare June 26, 2022 09:31

maflcko reviewed Jun 26, 2022

View reviewed changes

jarolrod reviewed Jun 27, 2022

View reviewed changes

maflcko merged commit fe5911e into bitcoin:master Jun 27, 2022

hebasto deleted the 220623-vs2022 branch June 27, 2022 06:14

hebasto mentioned this pull request Jun 27, 2022

Revert "ci: Increase CPU number for "Win64 native" task" #25483

Merged

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 27, 2022

Merge bitcoin#25460: ci: Update Windows task image up to visualstudio…

36516c0

…2022

hebasto mentioned this pull request Sep 30, 2022

ci: Bump vcpkg to the latest version 2022.09.27 #26211

Merged

bitcoin locked and limited conversation to collaborators Jun 27, 2023

Conversation

hebasto commented Jun 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

maflcko commented Jun 24, 2022

Uh oh!

maflcko commented Jun 24, 2022

Uh oh!

hebasto commented Jun 24, 2022

Uh oh!

hebasto commented Jun 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

hebasto commented Jun 25, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hebasto Jun 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hebasto Jun 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maflcko commented Jun 26, 2022

Uh oh!

sipsorcery commented Jun 26, 2022

Uh oh!

sipsorcery commented Jun 26, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hebasto commented Jun 26, 2022

Uh oh!

sipsorcery commented Jun 26, 2022

Uh oh!

DrahtBot commented Jun 26, 2022

Conflicts

Uh oh!

jarolrod left a comment

Choose a reason for hiding this comment

Uh oh!

hebasto commented Jun 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hebasto commented Jun 23, 2022 •

edited

Loading

hebasto commented Jun 24, 2022 •

edited

Loading

hebasto Jun 25, 2022 •

edited

Loading

hebasto Jun 26, 2022 •

edited

Loading