refactor: Move inbound eviction logic to its own translation unit#25500
refactor: Move inbound eviction logic to its own translation unit#25500fanquake merged 4 commits intobitcoin:masterfrom
Conversation
dergoegge
force-pushed
the
2022-06-evictionman-1ofN
branch
from
1ccde4c to
651c43f
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
dergoegge
force-pushed
the
2022-06-evictionman-1ofN
branch
from
651c43f to
06d45ac
Compare
dergoegge
force-pushed
the
2022-06-evictionman-1ofN
branch
2 times, most recently
from
4f04786 to
2eb7256
Compare
jnewbery
left a comment
jnewbery
left a comment
There was a problem hiding this comment.
utACK 2eb7256b643012b00f98997150ad753aa6d0a22b
|
utACK 2eb7256b643012b00f98997150ad753aa6d0a22b modulo @jnewbery's nits. Regardless of the larger effort, I think this stands on its own as a nice cleanup and small fuzzing improvement. |
dergoegge
force-pushed
the
2022-06-evictionman-1ofN
branch
from
2eb7256 to
0101d2b
Compare
|
utACK 0101d2b |
|
utACK 0101d2b. I quickly verified with |
| #include <chainparams.h> | ||
| #include <common/bloom.h> | ||
| #include <compat.h> | ||
| #include <node/connection_types.h> |
There was a problem hiding this comment.
nit: Just noticed these are now out of the recommended include order
7 participants
This PR splits of the first couple commits from #25268 that move the inbound eviction logic from
net.{h,cpp}toeviction.{h,cpp}.Please look at #25268 for motivation and conceptual review.