refactor: Move m_num_unconnecting_headers_msgs out of cs_main guard#25555
Closed
maflcko wants to merge 1 commit intobitcoin:masterfrom
Hidden character warning
The head ref may contain hidden characters: "2207-p2p-less-cs_main-\ud83c\udf58"
Closed
refactor: Move m_num_unconnecting_headers_msgs out of cs_main guard#25555maflcko wants to merge 1 commit intobitcoin:masterfrom
maflcko wants to merge 1 commit intobitcoin:masterfrom
Conversation
sdaftuar
reviewed
Jul 6, 2022
maflcko
force-pushed
the
2207-p2p-less-cs_main-
branch
from
6eeeee5 to
fac7da8
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jul 7, 2022
maflcko
changed the title
maflcko
force-pushed
the
2207-p2p-less-cs_main-
branch
from
fac7da8 to
fa82e48
Compare
Member
|
Are you still working on this? |
maflcko
force-pushed
the
2207-p2p-less-cs_main-
branch
2 times, most recently
from
fa5585b to
fad5d82
Compare
Member
Author
|
Rebased, but closing for now to pick it up later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable does not need to be guarded by cs_main, so move it out of the cs_main scope. It is not used for validation-specific state, but only for headers-processing internal state and logging.