Move DEFAULT_MAX_ORPHAN_TRANSACTIONS to node/txorphanage.h#25564
Closed
maflcko wants to merge 2 commits intobitcoin:masterfrom
Hidden character warning
The head ref may contain hidden characters: "2207-txorphan-move-\ud83d\ude90"
Closed
Move DEFAULT_MAX_ORPHAN_TRANSACTIONS to node/txorphanage.h#25564maflcko wants to merge 2 commits intobitcoin:masterfrom
maflcko wants to merge 2 commits intobitcoin:masterfrom
Conversation
jonatack
reviewed
Jul 7, 2022
maflcko
force-pushed
the
2207-txorphan-move-
branch
from
fa17d03 to
dddd207
Compare
shaavan
approved these changes
Jul 7, 2022
Contributor
shaavan
left a comment
shaavan
left a comment
There was a problem hiding this comment.
Code Review ACK dddd207b093a2c44f8f12bcc2ee6244fe5143f0d
- Verified that the scripted diff script works correctly, and the consequent diff is the same as the first commit.
- Verified that the files are correctly sorted after the renaming.
- I agree with converting
const->constexpr, which makes the variable a compile-time constant.
maflcko
force-pushed
the
2207-txorphan-move-
branch
from
dddd207 to
fa6e073
Compare
shaavan
approved these changes
Jul 8, 2022
Contributor
shaavan
left a comment
shaavan
left a comment
There was a problem hiding this comment.
reACK fa6e0734f5c2acc9e9b8de287c0da0f84fe87373
Changes since my last review:
- Rebased over current master
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
glozow
reviewed
Jul 8, 2022
Member
glozow
left a comment
glozow
left a comment
There was a problem hiding this comment.
Concept ACK, light code review looks correct to me
This was referenced Jul 8, 2022
This was referenced Jul 14, 2022
maflcko
force-pushed
the
2207-txorphan-move-
branch
from
fa6e073 to
fa0096a
Compare
added 2 commits
July 19, 2022 09:21
-BEGIN VERIFY SCRIPT- # Move module git mv src/txorphanage.cpp src/node/ git mv src/txorphanage.h src/node/ # Replacements sed -i 's:txorphanage\.h:node/txorphanage.h:g' $(git grep -l txorphanage) sed -i 's:txorphanage\.cpp:node/txorphanage.cpp:g' $(git grep -l txorphanage) sed -i 's:TXORPHANAGE_H:NODE_TXORPHANAGE_H:g' $(git grep -l TXORPHANAGE_H) -END VERIFY SCRIPT-
Also, sort file list after rename
maflcko
force-pushed
the
2207-txorphan-move-
branch
from
fa0096a to
fa999c3
Compare
Member
Author
|
Rebased |
This was referenced Jul 20, 2022
Member
Author
|
Closing for now to open review for other pulls. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not meaninful to run txorphanage without a node (validation, chainstate, mempool, rpc, ...). The module is in the node library and won't be added to the kernel library. Thus, it should be moved to
src/node.Also, move
DEFAULT_MAX_ORPHAN_TRANSACTIONStonode/txorphanage.h, as it logically belongs toTxOrphanage::m_orphansand not toPeerManager.