refactor: replace RecursiveMutex cs_sendProcessing with Mutex#25597
Closed
theStack wants to merge 1 commit intobitcoin:masterfrom
Closed
refactor: replace RecursiveMutex cs_sendProcessing with Mutex#25597theStack wants to merge 1 commit intobitcoin:masterfrom
cs_sendProcessing with Mutex#25597theStack wants to merge 1 commit intobitcoin:masterfrom
Conversation
This mutex is currently only acquired at one location in the code, apparently with the intention to execute the method for sending messages (`NetEventsInterface::SendMessages(...)`) in serial order, in the case that we ever had more than one message thread. With no possibility to re-acquire the mutex in the same thread, there is no reason for it to be a RecursiveMutex, so we can change it to an ordinary Mutex instead.
Member
|
See also b1af785 ( |
Contributor
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
Member
|
Are you still working on this? |
Member
35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mutex
cs_sendProcessingis currently only acquired at one location in the code:bitcoin/src/net.cpp
Lines 1998 to 2001 in 7d258ee
apparently with the intention to execute the method for sending messages (
NetEventsInterface::SendMessages(...)) in serial order, in the case that we ever had more than one message handling thread. With no possibility to re-acquire the mutex in the same thread, there is no reason for it to be a RecursiveMutex, so we can change it to an ordinary Mutex instead.(An alternative would be to just get rid of the mutex, as it currently doesn't serve any purpose, as long as we only have one message handling thread.)