Skip to content

doc: assumeutxo: format tables to be aligned in plain-text#25598

Closed
theStack wants to merge 1 commit intobitcoin:masterfrom
theStack:202207-doc-assumeutxo-nicer_plaintext_tables
Closed

doc: assumeutxo: format tables to be aligned in plain-text#25598
theStack wants to merge 1 commit intobitcoin:masterfrom
theStack:202207-doc-assumeutxo-nicer_plaintext_tables

Conversation

@theStack
Copy link
Contributor

@theStack theStack commented Jul 12, 2022

This simple PR increases the plain-text readability of the assumeutxo design document by aligning the table columns, without changing the look of the rendered markdown output.

@fanquake fanquake added the Docs label Jul 12, 2022
@fanquake fanquake requested a review from jamesob July 12, 2022 17:56
shaavan
shaavan approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@shaavan shaavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 46b10c4

  • A simple set of changes increasing the reliability of the plain text.
  • Verified that there is no rendered difference between the master and this PR.

@jamesob
Copy link
Contributor

jamesob commented Jul 12, 2022

+0

I heartily thank you for the attention paid to assumeutxo, but I don't really want to be on the hook for maintaining a bunch of spacing in raw text documents when it doesn't affect the rendered markdown output. I'm fine with this being merged if others feel strongly.

@DrahtBot
Copy link
Contributor

DrahtBot commented Jul 13, 2022 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@DrahtBot DrahtBot mentioned this pull request Jul 13, 2022
Closed
1 task
@theStack
Copy link
Contributor Author

theStack commented Jul 25, 2022

+0

I heartily thank you for the attention paid to assumeutxo, but I don't really want to be on the hook for maintaining a bunch of spacing in raw text documents when it doesn't affect the rendered markdown output. I'm fine with this being merged if others feel strongly.

Sure, no big deal, I'm also feeling fine if it's not merged. The idea is to make the reading experience of terminal users more pleasant, but it seems we belong to a species that is slowly dying out 😅

@theStack theStack closed this Jul 25, 2022
@bitcoin bitcoin locked and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jamesob jamesob Awaiting requested review from jamesob

1 more reviewer

@shaavan shaavan shaavan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@theStack @jamesob @DrahtBot @shaavan @fanquake