refactor: univalue test cleanups#25617
Merged
maflcko merged 3 commits intobitcoin:masterfrom Jul 18, 2022
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jul 15, 2022
fanquake
force-pushed
the
univalue_test_consolidation
branch
from
49d600a to
ff6a608
Compare
Member
Author
|
Rebased and simplified to the non-controversial changes. |
fanquake
force-pushed
the
univalue_test_consolidation
branch
from
ff6a608 to
425f6ba
Compare
maflcko
reviewed
Jul 15, 2022
fanquake
force-pushed
the
univalue_test_consolidation
branch
from
425f6ba to
31d76f7
Compare
maflcko
reviewed
Jul 18, 2022
src/univalue/test/unitester.cpp
Outdated
Member
There was a problem hiding this comment.
It might be good to move this into a function, otherwise it will be hard to understand the purpose of the test from looking at the code.
Having references to downstream no-longer make sense now that we've unsubtree'd.
fanquake
force-pushed
the
univalue_test_consolidation
branch
from
31d76f7 to
1f0c83f
Compare
Member
|
Good catch on the test issue. Also, good cleanup. ACK 1f0c83f 🍎 Show signatureSignature: |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 18, 2022
1f0c83f refactor: remove BOOST_*_TEST_ macros (fanquake) 70d807c refactor: integrate no_nul into univalue unitester (fanquake) 98a0ae6 doc: remove references to downstream (fanquake) Pull request description: Remove references to "downstream" from makefiles, as they are now redundant. Remove `BOOST_TEST` macros in favour of just using functions. Add missing call to `univalue_push_throw` tests. ACKs for top commit: MarcoFalke: ACK 1f0c83f 🍎 Tree-SHA512: e0e1ec159a82ece9b364c656b3b49d98f72a04f2614eeb2a386825c3e37bb5a10416446a8ea22d9048227d96aca3e5c1a3dbf3264a290443add382ded073575c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove references to "downstream" from makefiles, as they are now redundant.
Remove
BOOST_TESTmacros in favour of just using functions.Add missing call to
univalue_push_throwtests.