refactor: Use chainman() helper consistently in ChainImpl#25638
Merged
maflcko merged 1 commit intobitcoin:masterfrom Jul 20, 2022
Hidden character warning
The head ref may contain hidden characters: "2207-chainman-\ud83d\udd49"
Merged
refactor: Use chainman() helper consistently in ChainImpl#25638maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
jamesob
reviewed
Jul 19, 2022
Contributor
jamesob
left a comment
jamesob
left a comment
There was a problem hiding this comment.
Concept ACK, will review shortly
shaavan
approved these changes
Jul 20, 2022
Contributor
shaavan
left a comment
shaavan
left a comment
There was a problem hiding this comment.
Code Review ACK fa32b1b
- I agree with making the code less verbose while maintaining the same logic behind it.
- Verified that using
chainman()is equivalent toAssert(m_node.chainman)
ChainstateManager& chainman() { return *Assert(m_context->chainman); }
- Verified that all instances of
Assert(m_node.chainman)are replaced withchainman().
Member
|
Post-merge ACK |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 20, 2022
…ChainImpl fa32b1b refactor: Use chainman() helper consistently in ChainImpl (MacroFake) Pull request description: Doing anything else will just lead to more verbose and inconsistent code. ACKs for top commit: fanquake: ACK fa32b1b - all instances of `Assert(m_node.chainman)` in node/interfaces replaced with `chainman()`, which is the same thing. shaavan: Code Review ACK fa32b1b Tree-SHA512: a417680f79c150e4431aa89bc9db79fdf2dd409419081eb243194837b4ab8d16434165393f39a157473802753843e8c5314ad05c569b4e9221ce29a9fd1cefb8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing anything else will just lead to more verbose and inconsistent code.