refactor: Remove unused includes from dbwrapper.h#25645
Merged
fanquake merged 4 commits intobitcoin:masterfrom Jul 19, 2022
Hidden character warning
The head ref may contain hidden characters: "2207-include-dbwrapper-\ud83d\udd19"
Merged
refactor: Remove unused includes from dbwrapper.h#25645fanquake merged 4 commits intobitcoin:masterfrom
fanquake merged 4 commits intobitcoin:masterfrom
Conversation
added 2 commits
July 19, 2022 14:12
This is needed for the next commit
They are needed, otherwise the next commit will not compile
Member
|
Concept ACK. |
Member
|
ACK if green tidy. Could also include rpc/fees.cpp should remove these lines:
- #include <policy/policy.h> // lines 9-9
- #include <util/system.h> // lines 19-19 |
added 2 commits
July 19, 2022 14:32
IWYU confirms that they are unused
maflcko
force-pushed
the
2207-include-dbwrapper-
branch
from
fa622e0 to
faf98ae
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
maflcko
changed the title
Member
|
It indeed does look a bit confusing. But I can still build from scratch on macOS 12.4 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 20, 2022
faf98ae Remove unused includes in rpc/fees.cpp (MacroFake) 1111dde Remove unused includes from dbwrapper.h (MacroFake) fa77fdd Add missing includes (MacroFake) fa869ce Add missing includes to node/chainstate (MacroFake) Pull request description: Unused includes are confusing, but also cause unrelated compile errors when the unused includes were to be removed. Fix that by adding the missing includes where they are needed and then remove them where they are not needed. This is also checked by iwyu. ACKs for top commit: hebasto: ACK faf98ae, I have reviewed the code and it looks OK, I agree it can be merged. jarolrod: Code Review ACK bitcoin@faf98ae Tree-SHA512: 75f3c6e6f6ecf8a98233e1a1463c75ca4e0eb3ec341150d274141072fe95413a3c2ec6386d1c527899cc63d43f63f5eb5991509847412773362808ddfb1bb435
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unused includes are confusing, but also cause unrelated compile errors when the unused includes were to be removed.
Fix that by adding the missing includes where they are needed and then remove them where they are not needed. This is also checked by iwyu.