refactor: Fix iwyu on node/chainstate#25668
Merged
maflcko merged 1 commit intobitcoin:masterfrom Jul 22, 2022
Hidden character warning
The head ref may contain hidden characters: "2207-iwyu-\ud83d\udc4f"
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
Author
Wasn't sure about that, as it was not yet added to iwyu. So it seems like a bug that there is a warning. |
Member
Yea. Will follow up |
Member
Author
|
I mean we could also just add it explicitly to iwyu to work around the bug? |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the CI warning on master: https://cirrus-ci.com/task/5398182703136768?logs=ci#L7020