univalue: Avoid std::string copies#25714
Merged
maflcko merged 2 commits intobitcoin:masterfrom Nov 14, 2022
Hidden character warning
The head ref may contain hidden characters: "2207-univalue-types-\ud83d\ude49"
Merged
Conversation
Member
|
cc @martinus |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
maflcko
force-pushed
the
2207-univalue-types-
branch
2 times, most recently
from
fad7b66 to
fa2ceb5
Compare
maflcko
force-pushed
the
2207-univalue-types-
branch
from
fa2ceb5 to
fa67d7c
Compare
ryanofsky
approved these changes
Sep 1, 2022
Contributor
ryanofsky
left a comment
ryanofsky
left a comment
There was a problem hiding this comment.
Code review ACK fa67d7cafccb88b508e4eecdd9d66c2582647851. Left some minor suggestions, not important
ryanofsky
approved these changes
Sep 1, 2022
maflcko
force-pushed
the
2207-univalue-types-
branch
2 times, most recently
from
fae9c86 to
fa61fd6
Compare
aureleoules
approved these changes
Nov 3, 2022
Contributor
aureleoules
left a comment
aureleoules
left a comment
There was a problem hiding this comment.
ACK fa61fd688fac7bc49844c8afef9f2116c7ac71dd
maflcko
force-pushed
the
2207-univalue-types-
branch
from
fa61fd6 to
fa09525
Compare
Contributor
|
Code review ACK fa09525 |
martinus
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shouldn't matter too much, unless a really large string is pushed into a json struct, but I think it also clarifies the code.