wallet: improve {LoadActive,Deactivate}ScriptPubKeyMan log#25790
Merged
achow101 merged 1 commit intobitcoin:masterfrom Aug 8, 2022
Merged
wallet: improve {LoadActive,Deactivate}ScriptPubKeyMan log#25790achow101 merged 1 commit intobitcoin:masterfrom
{LoadActive,Deactivate}ScriptPubKeyMan log#25790achow101 merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
Concept ACK |
achow101
reviewed
Aug 5, 2022
w0xlt
force-pushed
the
log_load_active_script_pubkeyman
branch
from
78914c2 to
b5a762a
Compare
Contributor
How could |
Contributor
Author
|
@theStack you are right. In master, the range is 0-3. I got that log from another development branch and thought it was from the master. |
Contributor
|
Code review ACK b5a762a |
Member
|
ACK b5a762a |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 8, 2022
…bKeyMan` log b5a762a wallet: improve `{LoadActive,Deactivate}ScriptPubKeyMan` log (w0xlt) Pull request description: This PR includes the output type description in the log. It currently shows the enum position, which is only useful if the reader knows the code. Master: ``` Setting spkMan to active: id = 9f..04, type = 3, internal = 0 Setting spkMan to active: id = 3d..21, type = 2, internal = 0 Setting spkMan to active: id = 69..d4, type = 0, internal = 1 Setting spkMan to active: id = 97..ea, type = 1, internal = 1 ``` PR: ``` Setting spkMan to active: id = 6a..4f, type = bech32m, internal = false Setting spkMan to active: id = 83..dc, type = legacy, internal = true Setting spkMan to active: id = 7e..5d, type = p2sh-segwit, internal = true Setting spkMan to active: id = bd..d2, type = bech32, internal = true Setting spkMan to active: id = 13...7c, type = bech32m, internal = true ``` ACKs for top commit: S3RK: Code review ACK b5a762a achow101: ACK b5a762a theStack: Code-review ACK b5a762a Tree-SHA512: 5a79706d5452e523b0456fb8435545c6c8e550b6722c0d7966af79011275a97ed97cab297562e031d601aa855118082c5b770af118783b1faaaec0cba9f9ee6a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the output type description in the log. It currently shows the enum position, which is only useful if the reader knows the code.
Master:
PR: