build: fix cleanup of test logs#25798
Merged
achow101 merged 1 commit intobitcoin:masterfrom Aug 11, 2022
Merged
Conversation
make clean currently looks for test.cpp.log, when it should be test.log.
jarolrod
approved these changes
Aug 8, 2022
Contributor
jarolrod
left a comment
jarolrod
left a comment
There was a problem hiding this comment.
ACK 5474f5c
on master
find . -name "*log" | wc -l
109
make[1]: *** [distcleancheck] Error 1
make: *** [distcheck] Error 1
on pr branch
find . -name "*log" | wc -l
2 (config.log)
=================================================
bitcoin-23.99.0 archives ready for distribution:
bitcoin-23.99.0.tar.gz
=================================================
|
Confirming @jarolrod's results on ACK 5474f5c Results on master (c012875) On this PR (5474f5c) |
Contributor
|
GUIX hashes x86: arm64: |
Member
|
ACK 5474f5c |
Contributor
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 11, 2022
Member
|
FWIW, the logs were in fact named *.cpp.log in older versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make cleancurrently looks fortest_name.cpp.log, when it should betest_name.log, meaning .log files are left after runningmake clean.Also fixes #21705.
make distcheckseems to work fine after the logs files are properly cleaned up:Probably broken in #19385 / #24715.
Guix Build (x86_64):