test: Use existing {Chainstate,Block}Man#25815
Merged
maflcko merged 1 commit intobitcoin:masterfrom Aug 11, 2022
Hidden character warning
The head ref may contain hidden characters: "2208-test-cherry-\ud83e\udd55"
Merged
Conversation
Use {Chain,}TestingSetup's existing {Chainstate,Block}Manager and avoid
unnecessarily creating a local one.
This also helps reduce the code diff for a later commit where we change
{Chainstate,Block}Manager's constructor signature.
Member
Author
|
(Taken from e6336ea7de0c9e91318e33023e236148a14b7fbd) |
|
ACK tested 2e79fb6 Thanks for the context in the linked PRs. 🙏 |
Contributor
|
ACK 2e79fb6. |
adam2k
approved these changes
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is split up because it is needed for two changes:
CDBWrapperand its kernel users fromArgsManager#25623