test: remove unused norm_prv parameter in descriptor_tests.cpp.#25863
Merged
fanquake merged 1 commit intobitcoin:masterfrom Aug 24, 2022
Merged
test: remove unused norm_prv parameter in descriptor_tests.cpp.#25863fanquake merged 1 commit intobitcoin:masterfrom
norm_prv parameter in descriptor_tests.cpp.#25863fanquake merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
Author
|
It seems the original intention was to use std::string norm1;
BOOST_CHECK(parse_priv->ToNormalizedString(keys_priv, norma1));
BOOST_CHECK(EqualDescriptor(norm1, norm_pub));But even descriptors that were parsed from an |
w0xlt
force-pushed
the
remove_norm_prv
branch
2 times, most recently
from
6992292 to
e5d77ce
Compare
Contributor
Author
|
Rebased. |
theStack
reviewed
Aug 20, 2022
Contributor
theStack
left a comment
theStack
left a comment
There was a problem hiding this comment.
Concept ACK, good catch!
Seems like some comments have been changed unnecessarily, see below.
Member
|
ACK 57d1367 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 24, 2022
…criptor_tests.cpp`. 57d1367 test: remove unused `norm_prv` parameter (w0xlt) Pull request description: This PR removes the unused `norm_prv` parameter in `src/test/descriptor_tests.cpp`. ACKs for top commit: achow101: ACK 57d1367 Tree-SHA512: 5b16b6bea94db0b5f2c3675b6529312b50e120d4ec7633e4184dd4ba6fc04e086efb273b9e61f748c8a15cbdc243450b09fc58ec7343379f3151a3b9e7e37106
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the unused
norm_prvparameter insrc/test/descriptor_tests.cpp.