wallet: AvailableCoins, simplify output script type acquisition#25933
Merged
achow101 merged 1 commit intobitcoin:masterfrom Sep 21, 2022
Merged
Conversation
Contributor
|
Concept ACK |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
aureleoules
reviewed
Sep 13, 2022
Contributor
aureleoules
left a comment
aureleoules
left a comment
There was a problem hiding this comment.
ACK 24c82ee0987a39a551f9ab40b95b72e3ed1e224f - LGTM
Contributor
rajarshimaitra
left a comment
rajarshimaitra
left a comment
There was a problem hiding this comment.
tACK 24c82ee0987a39a551f9ab40b95b72e3ed1e224f
Just one non-blocking nit comment not related to changes of this PR.
furszy
force-pushed
the
2022_wallet_availablecoins_type_cleanup
branch
from
24c82ee to
58b7df3
Compare
Member
Author
|
Done, added @rajarshimaitra feedback. |
w0xlt
approved these changes
Sep 21, 2022
Member
|
ACK 58b7df3 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 23, 2022
…ype acquisition 58b7df3 wallet: AvailableCoins, simplify output script type acquisition (furszy) Pull request description: There is an unnecessary `ExtractDestination()` call and subsequent result parse into an `CScriptID`. The `Solver()` call, which we are already doing below anyway, retrieves the script type and, in the P2SH case, the program id. ACKs for top commit: achow101: ACK 58b7df3 aureleoules: re-ACK 58b7df3 rajarshimaitra: ACK 58b7df3 w0xlt: ACK bitcoin@58b7df3 Tree-SHA512: 51080766877c34cb2232ee3a1cb6b6a62b829c9297c67b99577742b94854a737a74d248015a4603ca9b6cd0a3c9e1d6d78673ff3cc9fc65dd82deea72dc537fd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an unnecessary
ExtractDestination()call and subsequent result parse into anCScriptID.The
Solver()call, which we are already doing below anyway, retrieves the script type and, in the P2SH case, the program id.