test, build: Separate read_json function into its own module#25974
Merged
fanquake merged 1 commit intobitcoin:masterfrom Feb 1, 2023
Merged
test, build: Separate read_json function into its own module#25974fanquake merged 1 commit intobitcoin:masterfrom
read_json function into its own module#25974fanquake merged 1 commit intobitcoin:masterfrom
Conversation
maflcko
reviewed
Sep 2, 2022
maflcko
reviewed
Sep 2, 2022
Malk8628
approved these changes
Sep 9, 2022
hebasto
force-pushed
the
220901-test
branch
from
57c9bfa to
aa326ab
Compare
Member
Author
|
Updated 57c9bfa -> aa326ab (pr25974.01 -> pr25974.02):
|
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
Author
|
Rebased aa326ab -> 3394ad2 (pr25974.02 -> pr25974.03) due to the conflict with #26286. |
maflcko
reviewed
Jan 23, 2023
Member
Author
|
Rebased 3394ad2 -> 7a820ce (pr25974.03 -> pr25974.04):
|
fanquake
approved these changes
Jan 31, 2023
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 1, 2023
…its own module 7a820ce test, build: Separate `read_json` function into its own module (Hennadii Stepanov) Pull request description: Currently, 4 source files rely on the definition of the `read_json` function provided in `src/test/script_tests.cpp`. This PR breaks this entanglement, improves code structure and maintainability. ACKs for top commit: fanquake: ACK 7a820ce Tree-SHA512: f1567989f76cb54ab86cc48927851a8c424b08a9483d02d4918b629e0c792108bad4ccf7fa341d57b0921d91e84bf8fa3b9c07e5fdf12c64d9d5da83e4e464fb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, 4 source files rely on the definition of the
read_jsonfunction provided insrc/test/script_tests.cpp.This PR breaks this entanglement, improves code structure and maintainability.