build: fix depends bdb compilation for BSDs#26073
Merged
fanquake merged 1 commit intobitcoin:masterfrom Nov 28, 2022
Merged
Conversation
Currently, building bdb for *BSD HOSTs in depends fails with:
```bash
libtool: compile: clang -m64 -c -I. -I../dist/./.. -I/home/ubuntu/bitcoin/depends/x86_64-unknown-freebsd/include -D_THREAD_SAFE -pipe -std=c11 -O2 -Wno-error=implicit-function-declaration -Wno-error=format-security ../dist/./../mutex/mut_tas.c -fPIC -DPIC -o mut_tas.o
In file included from ../dist/./../mutex/mut_tas.c:11:
In file included from ./db_int.h:884:
In file included from ../dist/./../dbinc/mutex.h:15:
../dist/./../dbinc/mutex_int.h:932:2: error: unknown type name 'pthread_rwlock_t'
MUTEX_FIELDS /* Opaque thread mutex structures. */
^
../dist/./../dbinc/mutex_int.h:65:3: note: expanded from macro 'MUTEX_FIELDS'
pthread_rwlock_t rwlock; /* Read/write lock */ \
^
1 error generated.
```
Defining `_XOPEN_SOURCE` >=600 fixes access to the missing
`pthread_rwlock_t` definitions.
Member
|
Has this always been broken, or is it a regression? |
Member
Author
I think it's always been broken, but haven't tested extensively. |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
jarolrod
approved these changes
Oct 10, 2022
Contributor
jarolrod
left a comment
jarolrod
left a comment
There was a problem hiding this comment.
ACK 5b2529b
recreated by attempting to build for make HOST=x86_64-unknown-freebsd
and got the same error message on master:
../dist/./../dbinc/mutex_int.h:932:2: error: unknown type name 'pthread_rwlock_t'
MUTEX_FIELDS /* Opaque thread mutex structures. */
^
../dist/./../dbinc/mutex_int.h:65:3: note: expanded from macro 'MUTEX_FIELDS'
pthread_rwlock_t rwlock; /* Read/write lock */ \
^
with this pr i can properly configure and then build.
rw_lock is a part of POSIX.1-2001, making it a late addition; and reading the feature test macros manual, we do have to specify the minimum posix standard we need. Specifying _XOPEN_SOURCE is one way to do so and is the most appropriate way to do so here since the issue is isolated to this package.
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 1, 2022
5b2529b build: fix depends bdb compilation for BSDs (fanquake) Pull request description: Currently, building bdb for *BSD HOSTs in depends fails with: ```bash libtool: compile: clang -m64 -c -I. -I../dist/./.. -I/home/ubuntu/bitcoin/depends/x86_64-unknown-freebsd/include -D_THREAD_SAFE -pipe -std=c11 -O2 -Wno-error=implicit-function-declaration -Wno-error=format-security ../dist/./../mutex/mut_tas.c -fPIC -DPIC -o mut_tas.o In file included from ../dist/./../mutex/mut_tas.c:11: In file included from ./db_int.h:884: In file included from ../dist/./../dbinc/mutex.h:15: ../dist/./../dbinc/mutex_int.h:932:2: error: unknown type name 'pthread_rwlock_t' MUTEX_FIELDS /* Opaque thread mutex structures. */ ^ ../dist/./../dbinc/mutex_int.h:65:3: note: expanded from macro 'MUTEX_FIELDS' pthread_rwlock_t rwlock; /* Read/write lock */ \ ^ 1 error generated. ``` Defining `_XOPEN_SOURCE` >=600 fixes access to the missing `pthread_rwlock_t` definitions. ACKs for top commit: jarolrod: ACK 5b2529b Tree-SHA512: 76584bfef7a86c69a095eb722657aa681b95658a031ef2da79d91a616e5370da292a65e7d67cdf641711791422b8a407b647b630ad497ffb9908683479e6cfb6
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, building bdb for *BSD HOSTs in depends fails with:
Defining
_XOPEN_SOURCE>=600 fixes access to the missingpthread_rwlock_tdefinitions.