refactor: Remove unused CDataStream::rdbuf method#26258
Hidden character warning
refactor: Remove unused CDataStream::rdbuf method#26258fanquake merged 1 commit intobitcoin:masterfrom
Conversation
It is unused and seems unlikely to be ever used.
There was a problem hiding this comment.
Code-review ACK fabbbe3
Seems like this method was introduced by Satoshi and hasn't been used for >10 years (last use was removed with commit 5ce4c2a) has never been used 👀
stickies-v
left a comment
stickies-v
left a comment
There was a problem hiding this comment.
Compact() also seems unused, can remove that too?
Was this ever used? Looks like the commit you link to was a call to |
As opposed to rdbuf one could imagine a use case for this, so I kept it for now. But happy to drop as well if reviewers want that. |
Oh you're right, it seems the method you removed was indeed never used then 🤔 |
fabbbe3 Remove unused CDataStream::rdbuf method (MacroFake) Pull request description: It is unused and seems unlikely to be ever used. ACKs for top commit: theStack: Code-review ACK fabbbe3 aureleoules: ACK fabbbe3 Tree-SHA512: 5804642658f96a0fb51482ebf3a062bb0f997c1e0527455afa4aceeeb6c1ad139a98b14a7c8a0909daba733a83bdc24fcadad45060ead4be6eb3dc3e66c129e2
6 participants
It is unused and seems unlikely to be ever used.