test: Remove unused txmempool include from tests#26286
Merged
maflcko merged 2 commits intobitcoin:masterfrom Oct 19, 2022
Hidden character warning
The head ref may contain hidden characters: "2210-test-cleanup-\ud83d\udc3c"
Merged
test: Remove unused txmempool include from tests#26286maflcko merged 2 commits intobitcoin:masterfrom
maflcko merged 2 commits intobitcoin:masterfrom
Conversation
Member
Author
|
Follow-up to #26250 |
Member
|
Concept ACK - looks like some previously transitively included includes will need to be added: test/util_tests.cpp: In member function ‘void util_tests::util_seed_insecure_rand::test_method()’:
test/util_tests.cpp:1441:33: error: ‘sqrt’ was not declared in this scope
1441 | int err = 30*10000./mod*sqrt((1./mod*(1-1./mod))/10000.);
| ^~~~
make[2]: *** [Makefile:18499: test/test_bitcoin-util_tests.o] Error 1 |
Member
|
Concept ACK. |
maflcko
force-pushed
the
2210-test-cleanup-
branch
from
fa407d1 to
fae702d
Compare
Member
Author
|
I can reduce the fuzz compile time (user+kernel time) by 20% with a dirty |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
Concept ACK |
This was referenced Oct 11, 2022
Member
Author
|
Does anyone know why msvc is unable to link this? |
This was referenced Oct 11, 2022
Closed
Member
@sipsorcery @hebasto any thoughts? |
Member
--- a/build_msvc/test_bitcoin-qt/test_bitcoin-qt.vcxproj
+++ b/build_msvc/test_bitcoin-qt/test_bitcoin-qt.vcxproj
@@ -54,6 +54,9 @@
<ProjectReference Include="..\libbitcoin_zmq\libbitcoin_zmq.vcxproj">
<Project>{792d487f-f14c-49fc-a9de-3fc150f31c3f}</Project>
</ProjectReference>
+ <ProjectReference Include="..\libtest_util\libtest_util.vcxproj">
+ <Project>{1e065f03-3566-47d0-8fa9-daa72b084e7d}</Project>
+ </ProjectReference>
<ProjectReference Include="..\libleveldb\libleveldb.vcxproj">
<Project>{18430fef-6b61-4c53-b396-718e02850f1b}</Project>
</ProjectReference> |
This was referenced Oct 12, 2022
maflcko
force-pushed
the
2210-test-cleanup-
branch
from
872982e to
fad7f22
Compare
Co-authored-by: Aurèle Oulès <[email protected]>
aureleoules
approved these changes
Oct 18, 2022
Contributor
aureleoules
left a comment
aureleoules
left a comment
There was a problem hiding this comment.
reACK 1c48dae
Thanks for the co-author.
w0xlt
approved these changes
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems odd to include this heavy header in all tests despite it only being used in a few tests.
Can be reviewed with
--color-moved=dimmed-zebra --ignore-all-space