validation, zmq: pass block in UpdatedBlockTip to avoid duplicate read#26375
Closed
andrewtoth wants to merge 2 commits intobitcoin:masterfrom
Closed
validation, zmq: pass block in UpdatedBlockTip to avoid duplicate read#26375andrewtoth wants to merge 2 commits intobitcoin:masterfrom
andrewtoth wants to merge 2 commits intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
andrewtoth
force-pushed
the
no-read-zmq
branch
from
8685a97 to
7b631dc
Compare
w0xlt
approved these changes
Oct 25, 2022
Member
|
This will increase the memory use even if not using zmq. I guess it is fine because the queue is limited? |
Contributor
Author
That sounds accurate. It seems |
Contributor
Author
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jun 28, 2023
Github-Pull: bitcoin#26375 Rebased-From: 4a16416
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jun 28, 2023
Github-Pull: bitcoin#26375 Rebased-From: 7b631dc
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Aug 16, 2023
Github-Pull: bitcoin#26375 Rebased-From: 4a16416
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Aug 16, 2023
Github-Pull: bitcoin#26375 Rebased-From: 7b631dc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
CZMQPublishRawBlockNotifier::NotifyBlockis called it callsReadBlockFromDiskwith the passed in block index. However, we will always have already read this block into memory duringActivateBestChainand use it to callBlockConnected. We can check for the tip block there and pass that intoUpdatedBlockTipto avoid having the zmq notifier read the block. This also has the benefit of removing thenode/blockstorage.hdependency entirely from the zmq code, so we can continue working to removeReadBlockFromDiskout of global scope (#26316 (comment)).