build: copy config.{guess,sub} post autogen in zmq package#26421
Merged
fanquake merged 1 commit intobitcoin:masterfrom Feb 7, 2023
Merged
build: copy config.{guess,sub} post autogen in zmq package#26421fanquake merged 1 commit intobitcoin:masterfrom
fanquake merged 1 commit intobitcoin:masterfrom
Conversation
Otherwise our config.guess and config.sub will be copied over. This problem has been masked by the fact that modern systems ship with versions that recognise all the triplets we use (namely arm64-apple-darwin). However building on ubuntu 20.04 surfaces the issue. Fixes bitcoin#26420.
hebasto
approved these changes
Oct 30, 2022
Member
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
ACK 1914e47, tested on Ubuntu 18.04.
Updating of config.{guess,sub} files was introduced in 0d1f38c. And it worked well until got broken in 6897c4b, where the added ./autogen.sh invocation overwrites them back.
Does it worth moving such copying commands from $(package)_preprocess_cmds into $(package)_config_cmds for all packages, for the sake of consistency?
Contributor
Guix builds
|
Member
|
Hmm, won't this break native builds that require a newer config.* than we ship? |
Contributor
Contributor
|
GUIX hashes x86: arm64: |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Member
Author
Possibly, however I don't think we've ever run into an instance of that happening. More often than not, the issue is the opposite, and the system config.guess/sub are not new enough. Hence why we use this copying-over method in multiple other depends packages; it's been a necessity for RISC-V and arm64-darwin. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 7, 2023
…mq package 1914e47 build: copy config.{guess,sub} post autogen in zmq package (fanquake) Pull request description: Otherwise our config.guess and config.sub will be copied over. This problem has been masked by the fact that modern systems ship with versions that recognise all the triplets we use (namely arm64-apple-darwin). However building on ubuntu 20.04 surfaces the issue. Fixes bitcoin#26420. ACKs for top commit: hebasto: ACK 1914e47, tested on Ubuntu 18.04. Tree-SHA512: dff64c3c62d9f8fc205e5a4dffe8befd58838418d073a15dfe304a0f64b182dfffd9dcf98b53df44bfab905c12a62d03cd5c0f91fa7c4b246ac21ae5f20540fd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise our config.guess and config.sub will be copied over. This problem has been masked by the fact that modern systems ship with versions that recognise all the triplets we use (namely arm64-apple-darwin). However building on ubuntu 20.04 surfaces the issue.
Fixes #26420.