test: Add getpeerinfo test for missing version message#26519
Merged
maflcko merged 1 commit intobitcoin:masterfrom Nov 18, 2022
Hidden character warning
The head ref may contain hidden characters: "2211-test-rpc-no-ver-\ud83d\udcc2"
Merged
test: Add getpeerinfo test for missing version message#26519maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
jonatack
reviewed
Nov 17, 2022
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
|
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 18, 2022
…essage fa68d08 test: Add getpeerinfo test for missing version message (MacroFake) Pull request description: There seems to be a lot of discussion about behaviour/code that is completely untested. Fix this by adding a test. The test documents the current behaviour and helps to detect when the behaviour changes in the future. ACKs for top commit: jonatack: ACK fa68d08 mzumsande: Code Review ACK fa68d08 Tree-SHA512: d092b30d5bdb46712c91a7c5bd2d0c82a0da281f1460967aa4e32c648b15d8d97870ded9565a90af34874eb468aad8b99694a2485af6807994e7cfc05482aa8c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be a lot of discussion about behaviour/code that is completely untested.
Fix this by adding a test. The test documents the current behaviour and helps to detect when the behaviour changes in the future.