refactor: Rename local variable to distinguish it from type alias#26624
Merged
glozow merged 1 commit intobitcoin:masterfrom Dec 5, 2022
Merged
refactor: Rename local variable to distinguish it from type alias#26624glozow merged 1 commit intobitcoin:masterfrom
glozow merged 1 commit intobitcoin:masterfrom
Conversation
The `txiter` type alias is declared in the `txmempool.h`.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
stickies-v
approved these changes
Dec 2, 2022
Contributor
stickies-v
left a comment
stickies-v
left a comment
There was a problem hiding this comment.
ACK 1984db1
Straightforward change, better to not have naming conflicts.
Comment on lines
+2294
to
+2296
| auto tx_iter = m_mempool.GetIter(tx->GetHash()); | ||
| if (tx_iter) { | ||
| const CTxMemPoolEntry::Parents& parents = (*tx_iter)->GetMemPoolParentsConst(); |
Contributor
There was a problem hiding this comment.
nit, while touching:
Suggested change
| auto tx_iter = m_mempool.GetIter(tx->GetHash()); | |
| if (tx_iter) { | |
| const CTxMemPoolEntry::Parents& parents = (*tx_iter)->GetMemPoolParentsConst(); | |
| auto tx_iter{m_mempool.GetIter(tx->GetHash())}; | |
| if (tx_iter) { | |
| const CTxMemPoolEntry::Parents& parents{(*tx_iter)->GetMemPoolParentsConst()}; |
vasild
approved these changes
Dec 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
txitertype alias is declared in thetxmempool.h:bitcoin/src/txmempool.h
Line 406 in 9e59d21