test: Run mempool_compatibility.py with MiniWallet#26640
Merged
achow101 merged 1 commit intobitcoin:masterfrom Dec 5, 2022
Hidden character warning
The head ref may contain hidden characters: "2212-test-mini-wallet-mempool-\ud83d\ude8c"
Merged
test: Run mempool_compatibility.py with MiniWallet#26640achow101 merged 1 commit intobitcoin:masterfrom
achow101 merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
maflcko
force-pushed
the
2212-test-mini-wallet-mempool-
branch
from
fa2011f to
fa43f60
Compare
Member
Author
|
It doesn't matter if the txs are descendants/ancestors of each other, so I just did that to make the diff even smaller. |
Member
|
ACK fa43f60
|
Member
|
ACK fa43f60 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using the already existing miniwallet, the test can be run even when no wallet is compiled.