build: Update libmultiprocess library#26672
Merged
fanquake merged 1 commit intobitcoin:masterfrom Dec 10, 2022
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Replacing `install` with `install-lib` and `install-bin` is not strictly necessary just to update the library, but it takes advantage of recent changes in the new version, and makes the build more minimal.
Member
Author
|
Updated 2a2dd0a -> 1986f12 (pr26672.01 -> pr26672.02, diff):
|
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 10, 2022
1986f12 build: Update `libmultiprocess` library (Hennadii Stepanov) Pull request description: This update in particular includes: - bitcoin-core/libmultiprocess#78 which is [required](bitcoin#25972 (comment)) for bitcoin#25972 - bitcoin-core/libmultiprocess#74 - bitcoin-core/libmultiprocess#70 ACKs for top commit: ryanofsky: Code review ACK 1986f12 Tree-SHA512: 2d9fa72df5de7d5be37d77d479702cba36c45e9fa9d9fc27e58aac0437c39e4a1054c0ac53b612cb43e830982e444d98c7d3e651d093ac68344e66f4734227bb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update in particular includes:
InvokeContext::connectionmember bitcoin-core/libmultiprocess#78 which is required for build: no-longer disable WARN_CXXFLAGS when CXXFLAGS is set #25972install-libandinstall-binbuild targets bitcoin-core/libmultiprocess#74pthread_threadid_npbitcoin-core/libmultiprocess#70