refactor: walletdb: drop unused FindWalletTx parameter and rename#26702
Closed
theStack wants to merge 1 commit intobitcoin:masterfrom
Closed
refactor: walletdb: drop unused FindWalletTx parameter and rename#26702theStack wants to merge 1 commit intobitcoin:masterfrom
FindWalletTx parameter and rename#26702theStack wants to merge 1 commit intobitcoin:masterfrom
Conversation
Since commit 3340dba ("Remove -zapwallettxes"), the `FindWalletTx` helper is only needed to read tx hashes, so drop the other parameter and rename the method accordingly.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
code review ACK f496528 |
maflcko
changed the title
FindWalletTx parameter and renameFindWalletTx parameter and rename
Member
|
ACK f496528 |
achow101
added a commit
to bitcoin-core/gui
that referenced
this pull request
Jan 3, 2023
…letTx` parameter and rename f496528 walletdb: refactor: drop unused `FindWalletTx` parameter and rename (Sebastian Falbesoner) Pull request description: Since commit 3340dba ("Remove -zapwallettxes"), the `FindWalletTx` helper is only needed to read tx hashes, so drop the other parameter and rename the method accordingly. ACKs for top commit: S3RK: code review ACK f496528 achow101: ACK f496528 vincenzopalazzo: ACK bitcoin/bitcoin@f496528 Tree-SHA512: ead85bc724462f9e920f9d7fe89679931361187579ffd6e63427c8bf5305cd5f71da24ed84f3b1bd22a12be46b5abec13f11822e71a3e1a63bf6cf49de950ab5
Member
|
This has been merged. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 4, 2023
…arameter and rename f496528 walletdb: refactor: drop unused `FindWalletTx` parameter and rename (Sebastian Falbesoner) Pull request description: Since commit 3340dba ("Remove -zapwallettxes"), the `FindWalletTx` helper is only needed to read tx hashes, so drop the other parameter and rename the method accordingly. ACKs for top commit: S3RK: code review ACK f496528 achow101: ACK f496528 vincenzopalazzo: ACK bitcoin@f496528 Tree-SHA512: ead85bc724462f9e920f9d7fe89679931361187579ffd6e63427c8bf5305cd5f71da24ed84f3b1bd22a12be46b5abec13f11822e71a3e1a63bf6cf49de950ab5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since commit 3340dba ("Remove -zapwallettxes"), the
FindWalletTxhelper is only needed to read tx hashes, so drop the other parameter and rename the method accordingly.