The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #26705 (clang-tidy: Check headers and fixes them by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

ACK but I'm going to try and run clang-tidy myself, first time doing so it might take me a bit

was able to run clang-tidy but I only saw a message for this part of the code
FormatListN() : FormatList(nullptr, 0) {}
not sure how to get clang-tidy to complain about the 3 NULL values changed to nullptr

@kevkevinpal

not sure how to get clang-tidy to complain about the 3 NULL values changed to nullptr

To observe clang-tidy's errors, one could apply to the master branch a diff as follows:

--- a/src/.clang-tidy
+++ b/src/.clang-tidy
@@ -12,17 +12,9 @@ readability-redundant-declaration,
 readability-redundant-string-init,
 '
 WarningsAsErrors: '
-bugprone-argument-comment,
-bugprone-use-after-move,
-misc-unused-using-decls,
-modernize-use-default-member-init,
 modernize-use-nullptr,
-performance-for-range-copy,
-performance-move-const-arg,
-performance-unnecessary-copy-initialization,
-readability-redundant-declaration,
-readability-redundant-string-init,
 '
 CheckOptions:
  - key: performance-move-const-arg.CheckTriviallyCopyableMove
    value: false
+HeaderFilterRegex: '.'

and, for example, run a CI task locally:

$ MAKEJOBS="-j16" FILE_ENV="./ci/test/00_setup_env_native_tidy.sh" ./ci/test_run_all.sh

or in a personal Cirrus account: https://cirrus-ci.com/task/4659814702252032.

My local run has in output:

/home/hebasto/git/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/./tinyformat.h:511:23: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
            : m_value(NULL),
                      ^~~~
                      nullptr
/home/hebasto/git/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/./tinyformat.h:512:26: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
            m_formatImpl(NULL),
                         ^~~~
                         nullptr
/home/hebasto/git/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/./tinyformat.h:513:25: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
            m_toIntImpl(NULL)
                        ^~~~
                        nullptr
/home/hebasto/git/bitcoin/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/./tinyformat.h:1008:40: error: use nullptr [modernize-use-nullptr,-warnings-as-errors]
    public: FormatListN() : FormatList(0, 0) {}
                                       ^
                                       nullptr

@hebasto thanks I think I was able to figure it out, I ran the CI task locally and then did docker exec -it <containerid> /bin/bash then ran clang-tidy ./src/tinyformat.h and was able to get the correct warning message