test: call keypoolrefill with priv key disabled should throw an error#26723
Closed
brunoerg wants to merge 1 commit intobitcoin:masterfrom
Closed
test: call keypoolrefill with priv key disabled should throw an error#26723brunoerg wants to merge 1 commit intobitcoin:masterfrom
keypoolrefill with priv key disabled should throw an error#26723brunoerg wants to merge 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
brunoerg
force-pushed
the
2022-12-keypool-error-privatekey
branch
from
fd0b35e to
ec63a48
Compare
Contributor
|
ACK ec63a48 |
maflcko
pushed a commit
that referenced
this pull request
Dec 19, 2022
…d throw an error ec63a48 test: call `keypoolrefill` with private keys disabled should throw an error (brunoerg) Pull request description: This PR adds test coverage for the following error: https://github.com/bitcoin/bitcoin/blob/cb32328d1b80d0ccd6eb9532bd8fe4e0a4de385e/src/wallet/rpc/addresses.cpp#L332-L334 ACKs for top commit: aureleoules: ACK ec63a48 Tree-SHA512: b5deda8981ff472f290e6e16c8723a58e02cbe099afd1f672c099f4add0a1d9b192b11a2c3f0e11b96794671f6b9efa75812b7a174248d7c58d7fd7d3310e7b9
Member
|
Closing, as this has been merged. However wasn't this already covered in ? |
Contributor
Author
No, the error message is the same but the commands are different. |
Contributor
|
I also verified that this was not already covered by looking at https://marcofalke.github.io/btc_cov/total.coverage/src/wallet/rpc/addresses.cpp.gcov.html. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds test coverage for the following error:
bitcoin/src/wallet/rpc/addresses.cpp
Lines 332 to 334 in cb32328