wallet: Replace GetBalance() logic with AvailableCoins()#26756
wallet: Replace GetBalance() logic with AvailableCoins()#26756w0xlt wants to merge 3 commits intobitcoin:masterfrom
GetBalance() logic with AvailableCoins()#26756Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
w0xlt
force-pushed
the
balance_coin_selection
branch
2 times, most recently
from
ca8dbf6 to
7215a05
Compare
This allows `AvailableCoins()` to be used in multiple files without creating a circular dependency
Add to the `AvailableCoins()` function the ability to separate values by status and ownership of each coin.
w0xlt
force-pushed
the
balance_coin_selection
branch
from
7215a05 to
3a2bc11
Compare
|
Rebased. |
|
🐙 This pull request conflicts with the target branch and needs rebase. |
|
I think this will end up making |
|
I'd also prefer we stopped using A lot of bugs/strangeness in the wallet seems to come from the fact that we always need to iterate over a bunch of transactions to learn the state of our wallet. If we did track wallet state in one place, we could have well-scoped individual functions for specific tasks. |
|
Closing due to lack of interest in this approach. |
4 participants
This PR proposes a solution for #26500 by changing the
AvailableCoins()function to calculate values by status (TRUSTED,UNTRUSTED_PENDINGandIMMATURE) and ownership (MINE,WATCH_ONLY), eliminating theGetBalance()logic.The downside is that the cache is no longer used. Not sure about the performance implication, but if the approach is OK, caching can also be used with this solution.
This approach also fixes the bug mentioned at the end of the
wallet_abandonconflict.pyfile.