ci: Use clang-15 in tsan task by maflcko · Pull Request #26768 · bitcoin/bitcoin

maflcko · 2022-12-29T14:32:51Z

Generally it is best to use the latest clang version for sanitizers, because it comes with the most features and bugfixes.

So bump to clang-15, the latest release, for the tsan task.

The task was using clang-13 (instead of 14) due to a bug, see #24572 (comment). Bumping to 15 will hopefully fix this bug, as well as #26759 (comment)

DrahtBot · 2022-12-29T14:32:54Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

hebasto

Concept ACK.

ci/test/00_setup_env_native_tsan.sh

.cirrus.yml

maflcko · 2022-12-29T15:16:58Z

Temporarily set NO_QR=1 due to a libqrencode compile failure:

qrinput.c:1338:44: warning: overlapping comparisons always evaluate to true [-Wtautological-overlap-compare]
        if(input->head->mode != QR_MODE_STRUCTURE || input->head->mode != QR_MODE_ECI) {
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
split.c:287:11: warning: call to undeclared function 'strdup'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        newstr = strdup(str);
                 ^
split.c:287:9: error: incompatible integer to pointer conversion assigning to 'char *' from 'int' [-Wint-conversion]
        newstr = strdup(str);
               ^ ~~~~~~~~~~~
1 warning and 1 error generated.
make[3]: *** [Makefile:635: split.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
1 warning generated.
make[3]: Leaving directory '/tmp/cirrus-ci-build/depends/work/build/x86_64-pc-linux-gnu/qrencode/3.4.4-90541ff189b'

https://cirrus-ci.com/task/4504254476451840?logs=ci#L1259

ci/test/00_setup_env_native_tsan.sh

hebasto

ACK faa00ca

hebasto · 2022-12-29T17:54:26Z

ci/test/00_setup_env_native_tsan.sh

-export DEP_OPTS="CC=clang-13 CXX='clang++-13 -stdlib=libc++'"
+export DOCKER_NAME_TAG=debian:bookworm  # For clang-15
+export PACKAGES="clang-15 llvm-15 libc++abi-15-dev libc++-15-dev python3-zmq"
+export DEP_OPTS="CC=clang-15 CXX='clang++-15 -stdlib=libc++' NO_QR=1"  # qr disabled due to libqrencode 3.4.4 compile failure, https://github.com/bitcoin/bitcoin/pull/26768#issuecomment-1367403430


FWIW, bumping qrencode package version doesn't help. Maybe

--- a/depends/packages/qrencode.mk +++ b/depends/packages/qrencode.mk @@ -10,6 +10,7 @@ $(package)_config_opts += --disable-gprof --disable-gcov --disable-mudflap $(package)_config_opts += --disable-dependency-tracking --enable-option-checking $(package)_config_opts_linux=--with-pic $(package)_config_opts_android=--with-pic +$(package)_cflags = -Wno-error=int-conversion endef define $(package)_preprocess_cmds

and drop NO_QR=1?

Not sure. I'd prefer to keep build system changes separate from CI-only changes.

hebasto · 2022-12-29T21:31:24Z

https://api.cirrus-ci.com/v1/task/6394543940042752/logs/ci.log:

ThreadSanitizer: CHECK failed: sanitizer_common.h:511 "((i)) < ((size_))" (0xffffffff, 0x1b) (tid=40779)
    #0 __tsan::CheckUnwind() <null> (bitcoind+0x145acb) (BuildId: 7f013e5c75bdabf8cb1b8e9769998ecddb89b677)
    #1 __sanitizer::CheckFailed(char const*, int, char const*, unsigned long long, unsigned long long) <null> (bitcoind+0xc7704) (BuildId: 7f013e5c75bdabf8cb1b8e9769998ecddb89b677)
    #2 __tsan::ScopedReportBase::AddLocation(unsigned long, unsigned long) <null> (bitcoind+0x15721f) (BuildId: 7f013e5c75bdabf8cb1b8e9769998ecddb89b677)
    #3 __tsan::ReportRace(__tsan::ThreadState*, __tsan::RawShadow*, __tsan::Shadow, __tsan::Shadow, unsigned long) <null> (bitcoind+0x15967f) (BuildId: 7f013e5c75bdabf8cb1b8e9769998ecddb89b677)
    #4 __tsan::DoReportRace(__tsan::ThreadState*, __tsan::RawShadow*, __tsan::Shadow, __tsan::Shadow, unsigned long) <null> (bitcoind+0x14926c) (BuildId: 7f013e5c75bdabf8cb1b8e9769998ecddb89b677)
    #5 __tsan::FdClose(__tsan::ThreadState*, unsigned long, int, bool) <null> (bitcoind+0xdd150) (BuildId: 7f013e5c75bdabf8cb1b8e9769998ecddb89b677)
    #6 closedir <null> (bitcoind+0xe6b25) (BuildId: 7f013e5c75bdabf8cb1b8e9769998ecddb89b677)
    #7 leveldb::(anonymous namespace)::PosixEnv::GetChildren(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>>>*) src/leveldb/util/env_posix.cc:599:5 (bitcoind+0xae7e28) (BuildId: 7f013e5c75bdabf8cb1b8e9769998ecddb89b677)
    #8 leveldb::DBImpl::DeleteObsoleteFiles() src/leveldb/db/db_impl.cc:237:9 (bitcoind+0xaaef3d) (BuildId: 7f013e5c75bdabf8cb1b8e9769998ecddb89b677)
    #9 leveldb::DBImpl::BackgroundCompaction() src/leveldb/db/db_impl.cc:752:5 (bitcoind+0xab3668) (BuildId: 7f013e5c75bdabf8cb1b8e9769998ecddb89b677)
    #10 leveldb::DBImpl::BackgroundCall() src/leveldb/db/db_impl.cc:687:5 (bitcoind+0xab2d10) (BuildId: 7f013e5c75bdabf8cb1b8e9769998ecddb89b677)
    #11 leveldb::DBImpl::BGWork(void*) src/leveldb/db/db_impl.cc:676:34 (bitcoind+0xab2c4b) (BuildId: 7f013e5c75bdabf8cb1b8e9769998ecddb89b677)
    #12 leveldb::(anonymous namespace)::PosixEnv::BackgroundThreadMain() src/leveldb/util/env_posix.cc:830:5 (bitcoind+0xaebc73) (BuildId: 7f013e5c75bdabf8cb1b8e9769998ecddb89b677)
    #13 leveldb::(anonymous namespace)::PosixEnv::BackgroundThreadEntryPoint(leveldb::(anonymous namespace)::PosixEnv*) src/leveldb/util/env_posix.cc:736:10 (bitcoind+0xaebc73)
    #14 decltype(std::declval<void (*)(leveldb::(anonymous namespace)::PosixEnv*)>()(std::declval<leveldb::(anonymous namespace)::PosixEnv*>())) std::__1::__invoke[abi:v15006]<void (*)(leveldb::(anonymous namespace)::PosixEnv*), leveldb::(anonymous namespace)::PosixEnv*>(void (*&&)(leveldb::(anonymous namespace)::PosixEnv*), leveldb::(anonymous namespace)::PosixEnv*&&) /usr/lib/llvm-15/bin/../include/c++/v1/__functional/invoke.h:394:23 (bitcoind+0xaebe48) (BuildId: 7f013e5c75bdabf8cb1b8e9769998ecddb89b677)
    #15 void std::__1::__thread_execute[abi:v15006]<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct>>, void (*)(leveldb::(anonymous namespace)::PosixEnv*), leveldb::(anonymous namespace)::PosixEnv*, 2ul>(std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct>>, void (*)(leveldb::(anonymous namespace)::PosixEnv*), leveldb::(anonymous namespace)::PosixEnv*>&, std::__1::__tuple_indices<2ul>) /usr/lib/llvm-15/bin/../include/c++/v1/thread:284:5 (bitcoind+0xaebe48)
    #16 void* std::__1::__thread_proxy[abi:v15006]<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct>>, void (*)(leveldb::(anonymous namespace)::PosixEnv*), leveldb::(anonymous namespace)::PosixEnv*>>(void*) /usr/lib/llvm-15/bin/../include/c++/v1/thread:295:5 (bitcoind+0xaebe48)
    #17 __tsan_thread_start_func <null> (bitcoind+0xe10e6) (BuildId: 7f013e5c75bdabf8cb1b8e9769998ecddb89b677)
    #18 <null> <null> (libc.so.6+0x88fd3) (BuildId: a30a1e23fbf2879030fcc0ef73ddf83658a19337)
    #19 <null> <null> (libc.so.6+0x10966b) (BuildId: a30a1e23fbf2879030fcc0ef73ddf83658a19337)

maflcko · 2022-12-30T08:39:16Z

Might be best to revert everything and report the bug, given that it exists in clang-14 and -15.

hebasto · 2022-12-30T08:41:39Z

Might be best to revert everything and report the bug, given that it exists in clang-14 and -15.

Agree.

DrahtBot added the Tests label Dec 29, 2022

hebasto reviewed Dec 29, 2022

View reviewed changes

ci/test/00_setup_env_native_tsan.sh Outdated Show resolved Hide resolved

hebasto reviewed Dec 29, 2022

View reviewed changes

.cirrus.yml Outdated Show resolved Hide resolved

maflcko force-pushed the 2212-tsan-15- branch from fad3f96 to fa13f22 Compare December 29, 2022 15:14

hebasto reviewed Dec 29, 2022

View reviewed changes

ci/test/00_setup_env_native_tsan.sh Outdated Show resolved Hide resolved

ci: Use clang-15 in tsan task

faa00ca

maflcko force-pushed the 2212-tsan-15- branch from fa13f22 to faa00ca Compare December 29, 2022 15:30

hebasto approved these changes Dec 29, 2022

View reviewed changes

maflcko merged commit e9e2e87 into bitcoin:master Dec 29, 2022

maflcko deleted the 2212-tsan-15-👺 branch December 29, 2022 19:30

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 30, 2022

Merge bitcoin#26768: ci: Use clang-15 in tsan task

7f42589

bitcoin locked and limited conversation to collaborators Dec 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: Use clang-15 in tsan task#26768

Hidden character warning

ci: Use clang-15 in tsan task#26768
maflcko merged 1 commit intobitcoin:masterfrom
maflcko:2212-tsan-15-👺

maflcko commented Dec 29, 2022 •

edited

Loading

Uh oh!

DrahtBot commented Dec 29, 2022 •

edited

Loading

Uh oh!

hebasto left a comment

Uh oh!

Uh oh!

Uh oh!

maflcko commented Dec 29, 2022 •

edited

Loading

Uh oh!

Uh oh!

hebasto left a comment

Uh oh!

hebasto Dec 29, 2022 •

edited

Loading

Uh oh!

maflcko Dec 29, 2022

Uh oh!

hebasto commented Dec 29, 2022

Uh oh!

maflcko commented Dec 30, 2022

Uh oh!

hebasto commented Dec 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

maflcko commented Dec 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Dec 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

maflcko commented Dec 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

hebasto Dec 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maflcko Dec 29, 2022

Choose a reason for hiding this comment

Uh oh!

hebasto commented Dec 29, 2022

Uh oh!

maflcko commented Dec 30, 2022

Uh oh!

hebasto commented Dec 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

maflcko commented Dec 29, 2022 •

edited

Loading

DrahtBot commented Dec 29, 2022 •

edited

Loading

maflcko commented Dec 29, 2022 •

edited

Loading

hebasto Dec 29, 2022 •

edited

Loading