refactor: importpubkey, importprivkey, importaddress, importmulti, and importdescriptors rpc#26840
Closed
KolbyML wants to merge 3 commits intobitcoin:masterfrom
Closed
refactor: importpubkey, importprivkey, importaddress, importmulti, and importdescriptors rpc#26840KolbyML wants to merge 3 commits intobitcoin:masterfrom
KolbyML wants to merge 3 commits intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
KolbyML
force-pushed
the
refactor-imports
branch
5 times, most recently
from
c284727 to
45c71bf
Compare
This was referenced Jan 7, 2023
KolbyML
force-pushed
the
refactor-imports
branch
5 times, most recently
from
de77e45 to
206def7
Compare
3 tasks
Member
|
@achow101 any thoughts on the best way/time to merge this? Conflicting with a lot of other changes. |
KolbyML
force-pushed
the
refactor-imports
branch
2 times, most recently
from
e60d258 to
aa67ca4
Compare
KolbyML
force-pushed
the
refactor-imports
branch
2 times, most recently
from
8fd8291 to
4fff303
Compare
This was referenced Jun 5, 2023
Contributor
|
Needs rebase if still relevant |
This was referenced Dec 5, 2023
Closed
Contributor
Author
|
closing due to bitcoin-core/gui#650 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a wallet rpc refactor from my gui pr bitcoin-core/gui#650
I was told by a contributor I should make a pr here for anything not in src/qt except for makefile/.ui stuff
So this pr refactors the RPC code so that it can be used through interfaces so there isn't a ton of code duplication more details would be in my bitcoin-core/gui pr.
For context this is apart of my Summer of Bitcoin project achow101 was my mentor.