build: Avoid BOOST_NO_CXX98_FUNCTION_BASE macro redefinition#26952
Merged
fanquake merged 1 commit intobitcoin:masterfrom Jan 31, 2023
Merged
build: Avoid BOOST_NO_CXX98_FUNCTION_BASE macro redefinition#26952fanquake merged 1 commit intobitcoin:masterfrom
BOOST_NO_CXX98_FUNCTION_BASE macro redefinition#26952fanquake merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
fanquake
reviewed
Jan 24, 2023
Member
Author
|
Updated 387a99d -> bb76ac4 (pr26952.01 -> pr26952.02, diff): |
Member
|
I don't think this works? # gcc-12 (Ubuntu 12.1.0-2ubuntu1~22.04) 12.1.0
make -C depends/ CC=gcc-12 CXX=g++-12
./autogen.sh
CONFIG_SITE=/home/ubuntu/bitcoin/depends/x86_64-pc-linux-gnu/share/config.site ./configure
checking whether BOOST_NO_CXX98_FUNCTION_BASE macro definition is needed... yes
make -j9
...
In file included from /home/ubuntu/bitcoin/depends/x86_64-pc-linux-gnu/include/boost/config.hpp:48,
from /home/ubuntu/bitcoin/depends/x86_64-pc-linux-gnu/include/boost/multi_index/hashed_index.hpp:16,
from ./txmempool.h:35,
from blockencodings.cpp:13:
/home/ubuntu/bitcoin/depends/x86_64-pc-linux-gnu/include/boost/config/stdlib/libstdcpp3.hpp:397: warning: "BOOST_NO_CXX98_FUNCTION_BASE" redefined
397 | #define BOOST_NO_CXX98_FUNCTION_BASE
| |
Member
Author
Thanks! Should be fixed now. |
fanquake
approved these changes
Jan 31, 2023
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 31, 2023
…o redefinition d4c59da build: Avoid `BOOST_NO_CXX98_FUNCTION_BASE` macro redefinition (Hennadii Stepanov) Pull request description: With GCC 12 and Boost 1.81 (from depends) having multiple warnings: ``` In file included from /home/hebasto/bitcoin/depends/x86_64-pc-linux-gnu/include/boost/config.hpp:48: /home/hebasto/bitcoin/depends/x86_64-pc-linux-gnu/include/boost/config/stdlib/libstdcpp3.hpp:397:9: warning: 'BOOST_NO_CXX98_FUNCTION_BASE' macro redefined [-Wmacro-redefined] #define BOOST_NO_CXX98_FUNCTION_BASE ^ <command line>:8:9: note: previous definition is here #define BOOST_NO_CXX98_FUNCTION_BASE 1 ^ 1 warning generated. ``` This PR fixes those warnings. Defining of the `BOOST_NO_CXX98_FUNCTION_BASE` macro was introduced in bitcoin#25436, but since boostorg/config#430, it is required to check it before adding. ACKs for top commit: fanquake: ACK d4c59da - it works now. Tree-SHA512: 53b9ddcf8dad729638ed41251e30c80f2d7d1ae3ffe47466865834f1f10184fe0881abeb339b3e46c270c3eb11fb63d19ab12cc9461bf5c2be12b4763c1b1c34
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With GCC 12 and Boost 1.81 (from depends) having multiple warnings:
This PR fixes those warnings.
Defining of the
BOOST_NO_CXX98_FUNCTION_BASEmacro was introduced in #25436, but since boostorg/config#430, it is required to check it before adding.