mapport: require miniupnpc API version 17 or later#27016
mapport: require miniupnpc API version 17 or later#27016fanquake merged 1 commit intobitcoin:masterfrom
Conversation
Version 17 is currently the latest version, and has been available since the release of 2.1. See: https://github.com/miniupnp/miniupnp/blob/master/miniupnpc/apiversions.txt.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Concept ACK |
|
Concept ACK. |
|
Now we can use Lines 1414 to 1418 in 7753efc pkgconfig/miniupnpc.pc is being provided with a newer libminiupnpc-dev package across of all major distros and macOS's Homebrew.
|
That doesn't quite work. But is already part of #22644 in any case. |
I'm not sure what it means, but my point is that using |
You can't use it, because it's not supported for mingw-w64 builds using 2.1. So while we could patch depends, distro/self-builds would be broken. |
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
ACK b3b673f, tested on Ubuntu 20.04 w/ and w/o libminiupnpc-dev package.
b3b673f mapport: require miniupnpc API version 17 or later (fanquake) Pull request description: Version 17 is currently the latest version, see: https://github.com/miniupnp/miniupnp/blob/master/miniupnpc/apiversions.txt, and has been available since the release of 2.1. 2.1 or newer is readily available across all distros, see https://repology.org/project/miniupnpc/versions, so drop support for the older API versions. Split out of bitcoin#22644. ACKs for top commit: hebasto: ACK b3b673f, tested on Ubuntu 20.04 w/ and w/o [`libminiupnpc-dev`](https://packages.ubuntu.com/focal/libminiupnpc-dev) package. TheCharlatan: ACK b3b673f Tree-SHA512: f53b36b82462c4ea83d9b83413dca8097885d1620f7ca0a53a79d6b3d3cf37c7773828b23f4278ccfcc3b14fcb0faffa35f60191b519b04570f3d2783d0303e2
5 participants
Version 17 is currently the latest version, see: https://github.com/miniupnp/miniupnp/blob/master/miniupnpc/apiversions.txt, and has been available since the release of 2.1. 2.1 or newer is readily available across all distros, see https://repology.org/project/miniupnpc/versions, so drop support for the older API versions.
Split out of #22644.