refactor: don't avoid sys/types.h when building for Windows#27098
Closed
fanquake wants to merge 1 commit intobitcoin:masterfrom
Closed
refactor: don't avoid sys/types.h when building for Windows#27098fanquake wants to merge 1 commit intobitcoin:masterfrom
fanquake wants to merge 1 commit intobitcoin:masterfrom
Conversation
We've already used it unguarded in `httpserver.cpp` for years, with no build issues.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. |
Member
Do Windows builds require any symbols from |
Member
Author
Aside from ultimately removing pointless per-platform conditionals,
|
maflcko
changed the title
Member
Member
Author
Yea, that's because this is a step towards doing so. |
Member
Author
|
Just going to combine this into #26832. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've already used it unguarded in
httpserver.cppfor years, with no build issues.Doesn't touch the usage in wallet/bdb.cpp. See #26832.