net: remove orphaned CSubNet::SanityCheck()#27106
Merged
fanquake merged 2 commits intobitcoin:masterfrom Feb 17, 2023
Merged
Conversation
CSubNet::SanityCheck() was added in bitcoin#20140, and not removed in bitcoin#22570 when it became orphaned code.
that was resolved in PR27036 "test: Remove last uses of snprintf and simplify" and while here, fix up 2 words in docs to make the spelling linter green again.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
fanquake
approved these changes
Feb 16, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
pinheadmz
approved these changes
Feb 16, 2023
Member
pinheadmz
left a comment
pinheadmz
left a comment
There was a problem hiding this comment.
ACK 30a3230
Show Signature
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
ACK 30a3230e86dfd49c771432be6219841df5066eb4
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmPudFYACgkQ5+KYS2KJ
yTrYnA/+LcTOT8/zvgcEeQ/nMhbO3LijgTmdio0OZS/dMc6SKdeAT/mDXv0ThjhB
+K7FuHY9fYO9sbXqPNkrbEfGR3iwqCNu5ElEAmvOMqVZIfkLHy//AX/uKNlUx2h7
1bICzt3PnnhaeGUWWxUeU+HFSpLikl6OHUYZLJfT+2VTz8rdMxhSY5iKSUEZNDKZ
J3D3B5nM8NtpkcMsuXJHEPsAqLvrYtt23Tw0dgTKGzfwr6Ai/WdcSSQn0jfHBIYc
mnj8dVG+hYLdTiVyXQ/bikf4M6kwPMn4H1QnHgHCFVEdlZyPvJ0wvPqTlLTFp009
8ZuGqm8VIfLntRNIhWe9FA7BZ6rz11uWfJgp+dmq9UGz0ohwZ0zI7NH9dhLYuRXN
NUdwLf8qBmdwsB7U9EVucApMFcCD7UGhn9cotQxPcJo/yTvMzL1GF/jLARxMLeod
dKGZBj4ymo6jxQZyGIgKs6LIS9IKjhm54qh2hXpm/4S2G4IktBvPts6HlDKPHdmB
PA+BEgDgnilHaxz/jnl3U2uK+D6v9ilv+LDtG0scBfdwx2zpn/VfdNtVbBtOTpWX
ILaA8JmaMcRytezYCDfFF+8KJLtX5JfIPWc9Po1tuRnpc4yKpf6xqeFlcvfLU67a
6J+VtZ2cznz3JRiEocvo6tbeoI0r+j4XYs711430al4pAQLDUQc=
=iM7z
-----END PGP SIGNATURE-----
pinheadmz's public key is on keybase
brunoerg
approved these changes
Feb 16, 2023
jonatack
deleted the
2023-02-rm-CSubNet-SanityCheck-and-snprintf-todo
branch
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 17, 2023
30a3230 script: remove out-of-date snprintf TODO (Jon Atack) 0e01514 net: remove orphaned CSubNet::SanityCheck() (Jon Atack) Pull request description: `CSubNet::SanityCheck()` was added in bitcoin#20140, and not removed in bitcoin#22570 when it became orphaned code. Also, remove an out-of-date `snprintf` TODO that was resolved in bitcoin#27036, and fix up 2 words to make the spelling linter green again. ACKs for top commit: fanquake: ACK 30a3230 pinheadmz: ACK 30a3230 brunoerg: crACK 30a3230 Tree-SHA512: f91a2a5af902d3b82ab496f19deeac17d58dbf72a8016e880ea61ad858b66e7ea0ae70b964c4032018eb3252cc34ac5fea163131c6a7f1baf87fc9ec9b5833d8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSubNet::SanityCheck()was added in #20140, and not removed in #22570 when it became orphaned code.Also, remove an out-of-date
snprintfTODO that was resolved in #27036, and fix up 2 words to make the spelling linter green again.