test: fix intermittent issue in p2p_disconnect_ban#27128
Merged
fanquake merged 1 commit intobitcoin:masterfrom Feb 20, 2023
Merged
test: fix intermittent issue in p2p_disconnect_ban#27128fanquake merged 1 commit intobitcoin:masterfrom
p2p_disconnect_ban#27128fanquake merged 1 commit intobitcoin:masterfrom
Conversation
When `node0` calls `disconnectnode` to disconnect `node1`, we should check in `node1` if it worked, because for `node0` the informations in `getpeerinfo` may be updated before really completing the disconnection.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Member
|
lgtm ACK 1819564 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 25, 2023
…ban` 1819564 test: fix intermittent issue in `p2p_disconnect_ban` (brunoerg) Pull request description: Fixes bitcoin#26808 When `node0` calls `disconnectnode` to disconnect `node1`, we should check in `node1` if it worked, because for `node0` the informations in `getpeerinfo` may be updated before really completing the disconnection. ACKs for top commit: MarcoFalke: lgtm ACK 1819564 Tree-SHA512: 53a386fc38e2faa6f6da3536e76857ff4b6f55e2590d73fe857b3fe5d0f3ff92c5c7e4abd50ab4be250cb2106a4d14ad95d4809ea60c6e00ed3ac0e71255b0b0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26808
When
node0callsdisconnectnodeto disconnectnode1, we should check innode1if it worked, because fornode0the informations ingetpeerinfomay be updated before really completing the disconnection.