refactor: Consistently use context args over gArgs in node/interfaces#27239
Merged
fanquake merged 2 commits intobitcoin:masterfrom Mar 11, 2023
Hidden character warning
The head ref may contain hidden characters: "2303-args-consistent-\ud83c\udfef"
Merged
refactor: Consistently use context args over gArgs in node/interfaces#27239fanquake merged 2 commits intobitcoin:masterfrom
fanquake merged 2 commits intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
DrahtBot
changed the title
Member
|
Concept ACK |
ryanofsky
approved these changes
Mar 10, 2023
Contributor
ryanofsky
left a comment
ryanofsky
left a comment
There was a problem hiding this comment.
Code review ACK facbb444bf5aea2bbaa4a4246a8a2c661d9bf314. Thanks for the cleanup. Could s/consistenly/consistently/ too
maflcko
changed the title
maflcko
force-pushed
the
2303-args-consistent-
branch
from
facbb44 to
fa3e9b4
Compare
Contributor
|
re-ACK facbb44 |
This was referenced Mar 10, 2023
Member
|
@TheCharlatan note that you've re-ACK'd the wrong commit hash. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 12, 2023
…gs in node/interfaces fa3e9b4 refactor: Consistently use args over gArgs in init.cpp (MarcoFalke) fa89112 refactor: Consistently use context args over gArgs in node/interfaces (MarcoFalke) Pull request description: Currently `node/interfaces.cpp` uses a mix of `gArgs` vs `m_context->args`. This is fine, because outside of tests those should be identical. However, it makes the code inconsistent and harder to use in tests. Fix that by using `args` from the context consistently. Do the same in `init.cpp`, where `gArgs` and `args` are inconsistently used in the same scope or even line. ACKs for top commit: ryanofsky: Code review ACK fa3e9b4 Tree-SHA512: bcd52f176794ebb1ecb9e1922411f7b84d212ae13bad314a1961b85f3077f645fca71fb0124c0889ebfdd8b59a0903b99b9985b1a4fb8f152aa6d7f0126fe5c7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
node/interfaces.cppuses a mix ofgArgsvsm_context->args. This is fine, because outside of tests those should be identical. However, it makes the code inconsistent and harder to use in tests.Fix that by using
argsfrom the context consistently. Do the same ininit.cpp, wheregArgsandargsare inconsistently used in the same scope or even line.