refactor, net processing: Avoid CNode::m_relays_txs usage#27270
refactor, net processing: Avoid CNode::m_relays_txs usage#27270fanquake merged 1 commit intobitcoin:masterfrom
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
utACK
@dergoegge Thanks for mentioning this understanding -- I hadn't looked at this code in a while, but I agree with this and I think this is helpful for everyone to understand as we do more work in this module. |
|
lgtm ACK 55c4795 |
…txs usage 55c4795 [net processing] Use TxRelay::m_relay_txs over CNode::m_relays_txs (dergoegge) Pull request description: `CNode::m_relays_txs` is meant to only be used for the eviction logic in `net`. `TxRelay::m_relay_txs` will hold the same value and is meant to be used on the application layer to determine if we will/should relay transactions to a peer. (Shameless plug: we should really better specify the interface for updating eviction data to avoid refactors like this in the future -> bitcoin#25572) ACKs for top commit: MarcoFalke: lgtm ACK 55c4795 Tree-SHA512: 59cfd23e32568fd96cda5570790e518242a6c76d4edf5b7d1a2a7f9724d590d2a38395504e05be0af4e98dd5c0056fc0be6568eab2818934692483a186e5181d
6 participants
CNode::m_relays_txsis meant to only be used for the eviction logic innet.TxRelay::m_relay_txswill hold the same value and is meant to be used on the application layer to determine if we will/should relay transactions to a peer.(Shameless plug: we should really better specify the interface for updating eviction data to avoid refactors like this in the future -> #25572)