Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
jnewbery
reviewed
Mar 24, 2023
Contributor
jnewbery
left a comment
jnewbery
left a comment
There was a problem hiding this comment.
utACK f824725be383e89346e2dc3269cc3d6aa533bcd3
One suggestion inline if you touch this PR again.
This was referenced Mar 24, 2023
dergoegge
force-pushed
the
2023-03-27257-followup
branch
from
f824725 to
cd0c8ee
Compare
theStack
approved these changes
Mar 27, 2023
Contributor
|
utACK cd0c8ee |
This was referenced Mar 28, 2023
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 28, 2023
cd0c8ee [net] Pass nRecvFloodSize to CNode (dergoegge) 860402e [net] Remove trivial GetConnectionType() getter (dergoegge) b5a85b3 [net] Delete CNetMessage copy constructor/assignment op (dergoegge) Pull request description: Follow-up PR for bitcoin#27257 * Deletes the copy constructor/assignment operator of `CNetMessage` * Removes trivial getter for the connection type * Avoids passing `nRecvFloodSize` to CNode methods by passing it to `CNode` on creation ACKs for top commit: jnewbery: utACK cd0c8ee theStack: ACK cd0c8ee Tree-SHA512: 673a758668617f69fba77e61f0eaa1538da27a4849c82c98742436692baa2d7f001129af3e7a66b160e599d12109dac08137a146f10ff9b9ebdc5c2237311d41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up PR for #27257
CNetMessagenRecvFloodSizeto CNode methods by passing it toCNodeon creation