wallet: allow importing descriptors that have no xprivs, even in a privkey-enabled wallet#27337
Closed
apoelstra wants to merge 1 commit intobitcoin:masterfrom
Closed
wallet: allow importing descriptors that have no xprivs, even in a privkey-enabled wallet#27337apoelstra wants to merge 1 commit intobitcoin:masterfrom
apoelstra wants to merge 1 commit intobitcoin:masterfrom
Conversation
…ivkey-enabled wallet
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
2 tasks
Contributor
Author
|
I'm going to close this; actually supporting what I want is a much more complicated job that I expected, and it would violate the scriptpubkeyman abstraction, so probably needs extensive discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing pubkey-only descriptors works fine as long as the wallet already has the required privkeys.
Happy to add whatever tests people advise me to.
Fixes #27336
Edit Never mind -- we can update balances but not sign coins. More work needs to be done to support this.