Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
stickies-v
approved these changes
Jun 14, 2023
Contributor
stickies-v
left a comment
stickies-v
left a comment
There was a problem hiding this comment.
ACK f74ffc03b4dbef0a59f86b9d52e814191440f3d3
Member
|
May also need 27777 and 27844 ? |
Github-Pull: bitcoin#27777 Rebased-From: fa9c65a
Github-Pull: bitcoin#27777 Rebased-From: fa12307
This should avoid a race where the kill is not done when spinning up the new container. podman stop waits 10 seconds by default. Github-Pull: bitcoin#27844 Rebased-From: faaa627
Github-Pull: bitcoin#27853 Rebased-From: ce887ea
Github-Pull: bitcoin#27853 Rebased-From: 7d452d8
Tee `arm_container` does not support 32-bit mode anymore. See: bitcoin#27879 Github-Pull: bitcoin#27886 Rebased-From: 016fe6d
Member
Author
Pulled them in. |
stickies-v
approved these changes
Jun 15, 2023
Member
Author
Added to the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently backports:
/deploymentinfo#27853amd64container in "ARM" task #27886Effectively also backports: #27562.