fuzz: wallet, add target for CoinControl#27902
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
brunoerg
left a comment
brunoerg
left a comment
There was a problem hiding this comment.
lf you remove the trailing whitespace in new lines, lint will be happy:
diff --git a/src/wallet/test/fuzz/coincontrol.cpp b/src/wallet/test/fuzz/coincontrol.cpp
@@ -0,0 +1,89 @@
+
+FUZZ_TARGET_INIT(coincontrol, initialize_coincontrol)
+
+ // Condition to avoid the assertion in GetInputWeight
Ayush170-Future
force-pushed
the
fuzz-coverage-coincontrol
branch
from
74be54a to
241ca23
Compare
|
Force pushed addressing @MarcoFalke and @brunoerg reviews.
|
kevkevinpal
left a comment
kevkevinpal
left a comment
There was a problem hiding this comment.
crACK 241ca232dcd0c38169423360de367caa9ee3f49b
checked that we're covering all the functions in ./src/wallet/coincontrol.h and ./src/wallet/coincontrol.cpp
have not yet run the fuzz tests on my local yet
Ayush170-Future
force-pushed
the
fuzz-coverage-coincontrol
branch
from
241ca23 to
40b333e
Compare
|
Force pushed addressing @kevkevinpal review.
|
|
reACK 40b333e |
|
lgtm ACK 40b333e |
|
Did the author or someone else run this with the ubsan+integer sanitizer to check for any issues before merge? |
dergoegge
left a comment
dergoegge
left a comment
There was a problem hiding this comment.
ACK 40b333e
Did the author or someone else run this with the ubsan+integer sanitizer to check for any issues before merge?
Yes I did for ~15min on 64 cores. Should be enough given that there isn't much code under test (it plateaued pretty quickly).
|
ACK 40b333e |
40b333e fuzz: wallet, add target for CoinControl (Ayush Singh) Pull request description: This PR adds fuzz coverage for `wallet/coincontrol`. Motivation: Issue [bitcoin#27272](bitcoin#27272 (comment)) The idea is to create different/unique instances of `COutPoint` by placing it inside the `CallOneOf` function, which may or may not be consumed by all of the `CoinControl` file's methods. This is my first PR on Bitcoin Core, and I will try my best to address any reviews/changes ASAP. I'm also working on fuzz harness files for other files in the wallet and plan to open PR for them soon. ACKs for top commit: kevkevinpal: reACK [40b333e](bitcoin@40b333e) MarcoFalke: lgtm ACK 40b333e achow101: ACK 40b333e brunoerg: crACK 40b333e dergoegge: ACK 40b333e Tree-SHA512: 174769f4e86df8590b532b85480fd620082587e84e50e49ca9b52f0588a219355362cefd66250dd9942e86019d27af4ca599b45e871e9f147d2cc0ba97c4aa7b
7 participants
This PR adds fuzz coverage for
wallet/coincontrol.Motivation: Issue #27272
The idea is to create different/unique instances of
COutPointby placing it inside theCallOneOffunction, which may or may not be consumed by all of theCoinControlfile's methods.This is my first PR on Bitcoin Core, and I will try my best to address any reviews/changes ASAP. I'm also working on fuzz harness files for other files in the wallet and plan to open PR for them soon.